About the wp_error parameter of the pre_reschedule_event filter

[tmatsuur]

I found a little something strange in the source code of cron.php.

It is in the wp_reschedule_event function.

$pre = apply_filters( 'pre_reschedule_event', null, $event );

The comment states that the wp_error parameter has been added,
and I think the following is correct:

$pre = apply_filters( 'pre_reschedule_event', null, $event, $wp_error );

[johnbillion]

Thanks @tmatsuur! Good spot.

[mukesh27]

52572.diff​ patch added.

[SergeyBiryukov]

Thanks for the patch! The alignment of the $wp_error parameter in the DocBlock should not be changed, though. It is aligned with the $pre and $event​ parameters above, not with the keys of the $event array.

[mukesh27]

Updated patch.

[mukesh27]

Thanks for review. 52572.2.diff​ patch updated.

[johnbillion]

52572.3.diff​ updates the existing tests to add assertions for the value of the $wp_error parameter that's passed to the filters.

[johnbillion]

52572.4.diff​ updates some formatting in the tests for consistency.

[tmatsuur]

Replying to johnbillion:

52572.4.diff​ updates some formatting in the tests for consistency.

Thanks @johnbillion .

I was impressed with the quick response.

[johnbillion]

In 50394:

Cron API: Add a missing $wp_error parameter to the pre_reschedule_event filter.

Props tmatsuur, mukesh27

Fixes #52572
See #49961