user-edit.php throw an empty error notice after clicking the password reset button

[audrasjb]

Related: #34281

On local instals of WordPress, the reset password email workflow may not be available. The issue is that the error notice is empty, so we don't have any information about the error.

See attached screenshot below.

[audrasjb]

After patch

[SergeyBiryukov]

Thanks for the patch! I have some concerns about the approach:

• The success parameter is documented as a boolean value, why are we comparing it to a string?
• The message parameter is documented as a string, why are we extracting it from an array?

It seems like the addInlineNotice() function is not being used correctly here.

[audrasjb]

Good points. I didn't dig so much into the issue, I only spotted that in case we have an error, the message variable contains an array, so it can't be displayed as a string in the notice paragraph:

0: [
    code: "retrieve_password_email_failure"
    message: "<strong>Error</strong>: The email could not be sent. Your site may not be correctly configured to send emails. <a href="https://wordpress.org/support/article/resetting-your-password/">Get support for resetting your password</a>."
]

But I'll leave this to more JS savvy people :)

[SergeyBiryukov]

In 50390:

Users: Correctly display an error message after clicking the "Send Reset Link" button.

The addInlineNotice() function expects a single string as a success or error message, not an array of strings.

Follow-up to [50129].

Props audrasjb.
Fixes #52573.