Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 15 months ago

#52576 closed defect (bug) (reported-upstream)

Message to please install Flashplayer can be retired now

Reported by: tobifjellner's profile tobifjellner Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.7
Component: Script Loader Keywords:
Focuses: Cc:

Description

Currently (as of Feb 19 2021) latest.zip still contains the following string in \wordpress\wp-includes\script-loader.php

'mejs.install-flash'       => __( 'You are using a browser that does not have Flash player enabled or installed. Please turn on your Flash player plugin or download the latest version from https://get.adobe.com/flashplayer/' )

Since Adobe now has officially killed this product, it's pointless to ask anyone to install it.

I understand that there probably is some functionality hidden behind this message, so it's not totally trivial. But it really would be good to remove this before version 5.7 ships.

Reported by @jowi2020

Change History (8)

This ticket was mentioned in Slack in #polyglots by tobifjellner. View the logs.


3 years ago

#2 @SergeyBiryukov
3 years ago

Thanks for the ticket!

The message comes from the MediaElement.js library, the string in wp-includes/script-loader.php is just to make sure the message can be translated to all the locales that WordPress supports.

While we could remove the message from script-loader.php, that would mean the message, when still displayed under any circumstances, would always be displayed in English.

From a consistency point of view, I think that as long as that message is still a part of MediaElement.js, it makes sense to keep it translatable, same as the other strings. When it's no longer a part of the library, it will be removed as part of updating to a new version in a ticket like #51315.

#3 @tobifjellner
3 years ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

Then I guess the most appropriate action is to report it upstream, so I just did: https://github.com/mediaelement/mediaelement/issues/2845

Thanks @SergeyBiryukov for the pointer

#4 @johnbillion
3 years ago

  • Milestone Awaiting Review deleted

#5 @fierevere
3 years ago

#52699 was marked as a duplicate.

#6 @ocean90
15 months ago

#57232 was marked as a duplicate.

#7 @NekoJonez
15 months ago

Is this going to get a milestone? Since, the string is still present.

#8 @costdev
15 months ago

The MediaElement.js library still contains this string, so I believe this change in Core is still waiting for a change there first.

Unfortunately, there have been not been any responses to the upstream issue yet.

Last edited 15 months ago by costdev (previous) (diff)
Note: See TracTickets for help on using tickets.