WordPress.org

Make WordPress Core

Opened 5 days ago

Closed 44 hours ago

Last modified 44 hours ago

#52612 closed enhancement (fixed)

Disable fast failing on GitHub Actions

Reported by: johnbillion Owned by: desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

The fail-fast option is enabled by default on GitHub Actions. This means if a job fails, all other jobs that have not yet run get automatically cancelled.

This is good for being alerted sooner to a failure, but bad when you're trying to identify if a failure is specific to one job or all jobs because all other remaining jobs get cancelled.

I propose setting fail-fast to false in our config.

Ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

Change History (4)

#1 @jorbin
5 days ago

This sounds good to me. :shipit:

#2 @desrosj
45 hours ago

  • Owner set to desrosj
  • Status changed from new to accepted

#3 @desrosj
44 hours ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 50435:

Build/Test Tools: Disable fail-fast for PHPUnit testing.

In GitHub Actions, there is a fail-fast option that will cancel all incomplete jobs within a workflow as soon as one failure is encountered. This defaults to true.

This is great for alerting you of a failure faster, but does not give you the full picture of what is failing. For example, it’s possible that there is a failing test on 2 versions of PHP, but not others. If fail-fast is enabled, it’s impossible to know this.

Even with fail-fast disabled, the workflow will still report a failure if one or more jobs produce a failing result.

Props johbillion, jorbin.
Fixes #52612.

#4 @desrosj
44 hours ago

  • Keywords dev-feedback needs-patch removed
  • Milestone changed from Awaiting Review to 5.8
Note: See TracTickets for help on using tickets.