Coding Standards fixes for WP 5.8

[SergeyBiryukov]

Previously:

• #51799 (5.7)
• #50767 (5.6)
• #49542 (5.5)
• #49222 (5.4)
• #47632 (5.3)
• #45934 (5.1)

[SergeyBiryukov]

In 50533:

Coding Standards: Remove some extra whitespace in sanitize_comment_cookies().

See #52627.

[SergeyBiryukov]

In 50557:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-upgrader.php.

See #52627.

[SergeyBiryukov]

In 50558:

Coding Standards: Use strict comparison for return type checks in a few functions:

• get_bookmark()
• get_comment()
• get_post()
• get_children()
• wp_get_recent_posts()
• wp_get_post_revision()
• wp_get_nav_menu_items()

Follow-up to [45710] for get_term(), [48507] for wpdb::get_row() and wpdb::get_results().

See #52627.

[SergeyBiryukov]

In 50560:

Coding Standards: Add missing semicolon to some endif keywords.

See #52627.

[SergeyBiryukov]

In 50561:

Coding Standards: Move some translator comments to the correct place.

Follow-up to [48172].

See #52627.

[SergeyBiryukov]

In 50618:

Coding Standards: Remove some extra whitespace in _wp_translate_postdata().

See #52627.

[davidbaumwald]

In [50631]:

Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

[davidbaumwald]

In 50632:

Coding Standards: Remove some extra whitespace in get_item_schema.

Introduced in [50527].

See #52627.

[mukesh27]

@davidbaumwald Do we need to remove parentheses from here ​https://github.com/WordPress/WordPress/blob/master/wp-includes/class-requests.php#L146?

Replying to davidbaumwald:

In [50631]:

Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

[davidbaumwald]

Replying to mukesh27:

@davidbaumwald Do we need to remove parentheses from here ​https://github.com/WordPress/WordPress/blob/master/wp-includes/class-requests.php#L146?

Replying to davidbaumwald:

In [50631]:

Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.

In [47198], parentheses were removed from include and require statements, as they are language constructs, not function calls. However, [50161] introduced a new require_once instance in wp-admin/options-privacy.php. This change removes the unnecessary parentheses.

See #53627.

@mukesh27 Good catch, but that's one of the third-party library exclusions. See https://core.trac.wordpress.org/browser/tags/5.7/phpcs.xml.dist#L116

[mukesh27]

@davidbaumwald Thanks for the information.

​https://github.com/WordPress/WordPress/commits/master/wp-includes/class-requests.php

If you check GitHub history for that file then you found that core developer's changed some code as per new possible updates.

[SergeyBiryukov]

In 50652:

Coding Standards: Use strict comparison in wp-admin/includes/class-core-upgrader.php.

See #52627.

[SergeyBiryukov]

In 50654:

Coding Standards: Move some translator comments to the correct place.

Follow-up to [46273], [50060], [50117].

See #52627.

[SergeyBiryukov]

Since [50060] and [50117] were in 5.7, going to merge [50654] to the 5.7 branch too.

[SergeyBiryukov]

In 50655:

Coding Standards: Move some translator comments to the correct place.

Follow-up to [46273], [50060], [50117].

Merges [50654] to the 5.7 branch.
See #52627.

[SergeyBiryukov]

In 50657:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-filesystem-*.php.

See #52627.

[SergeyBiryukov]

In 50658:

Coding Standards: Give some variables in WP_Importer a more meaningful name.

See #52627.

[SergeyBiryukov]

In 50664:

Coding Standards: Use strict comparison in wp-admin/includes/comment.php.

See #52627.

[SergeyBiryukov]

In 50665:

Coding Standards: Use strict comparison in wp-admin/includes/credits.php.

See #52627.

[SergeyBiryukov]

In 50689:

Coding Standards: Use strict comparison in wp-admin/includes/dashboard.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50696:

Coding Standards: Give a variable in wp-admin/themes.php a more meaningful name.

Follow-up to [20029].

See #52627.

[SergeyBiryukov]

In 50699:

Coding Standards: Simplify the check for parent terms in export_wp().

This is more consistent with similar checks elsewhere in core.

See #52627.

[SergeyBiryukov]

In 50700:

Coding Standards: Use strict comparison in wp-admin/includes/file.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50701:

Coding Standards: Rewrite a fragment in request_filesystem_credentials() for clarity and to avoid repetition.

Follow-up to [8540], [8865].

See #52627.

[SergeyBiryukov]

In 50706:

Coding Standards: Use strict comparison in wp-admin/includes/class-custom-background.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50707:

Coding Standards: Use strict comparison in wp-admin/includes/class-custom-image-header.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50759:

Coding Standards: Give a variable in WP_Automatic_Updater::after_core_update() a more meaningful name.

Follow-up to [25841], [25873], [25882].

See #52627.

[SergeyBiryukov]

In 50762:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-automatic-updater.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50767:

Coding Standards: Use strict comparison in wp-admin/includes/class-walker-nav-menu-edit.php.

See #52627.

[SergeyBiryukov]

In 50768:

Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-comments-list-table.php.

• Rename method argument in WP_Comments_List_Table::floated_admin_avatar() per the naming conventions.
• Use strict comparison in WP_Comments_List_Table::handle_row_actions().

See #52627.

[SergeyBiryukov]

In 50770:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-media-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

[davidbaumwald]

In 50779:

Coding Standards: Fix minor, inline spacing issue in wp-admin/setup-config.php.

See #52627.

[SergeyBiryukov]

In 50780:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-terms-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50783:

Coding Standards: Remove loose comparison in wp-admin/includes/plugin-install.php.

This more closely represents how the active installations count is displayed in the Plugin Directory.

See #52627.

[SergeyBiryukov]

In 50785:

Coding Standards: Use strict comparison in wp-admin/includes/update-core.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50795:

Coding Standards: Fix a precision alignment issue in wp-admin/includes/template.php.

Follow-up to [49223].

See #52627.

[SergeyBiryukov]

In 50804:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-posts-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50805:

Coding Standards: Fix a whitespace at end of line issue in wp-admin/includes/class-wp-comments-list-table.php.

Includes minor code layout fixes for better readability.

See #52627.

[SergeyBiryukov]

In 50832:

Coding Standards: Use strict comparison in wp-admin/includes/screen.php.

See #52627.

[SergeyBiryukov]

In 51047:

Coding Standards: Use strict comparison in wp-includes/class-wp-customize-nav-menus.php.

See #52627.

[SergeyBiryukov]

In 51070:

Coding Standards: Simplify the logic in WP_Widget::get_field_name() and ::get_field_id().

Includes minor code layout fixes for better readability.

Follow-up to [41292], [50953], [50961].

Props 5ubliminal, solarissmoke, tamlyn, jdgrimes, jorbin, stevenkword, drebbits.web, westonruter, jipmoors, justinahinon, helen, lukecarbis, Mte90, hellofromTonya, SergeyBiryukov.
See #16773, #52627.

[SergeyBiryukov]

In 51075:

Coding Standards: Use strict comparison in wp-admin/options-media.php.

See #52627.

[desrosj]

Today is beta 1 day. Since coding standards updates usually touch code, I'm going to close this out.

If there are any more changes required between now and the actual 5.8 release, this can be referenced and reopened if necessary.

[SergeyBiryukov]

In 51154:

Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls.

This brings some consistency with most other calls.

Follow-up to [23378], [25605], [34745], [36219], [44108], [46111], [48156].

See #52627.

[SergeyBiryukov]

In 51155:

Coding Standards: Remove a one-time $message variable in WordPress version requirement notices for bundled themes.

This makes the formatting of these messages more consistent.

Follow-up to [23816], [51154].

See #52627.

[SergeyBiryukov]

In 51158:

Coding Standards: Use consistent formatting for _wp_posts_page_notice() and _wp_block_editor_posts_page_notice().

Remove redundant casting to int for post ID, which is always an integer.

Follow-up to [51116].

See #45537, #52627.

[SergeyBiryukov]

In 51160:

I18N: Remove redundant default text domain parameter in some __() calls.

Follow-up to [43919], [44262], [48141], [50259].

See #52627.

[SergeyBiryukov]

In 51178:

Coding Standards: Bring some consistency to HTML formatting in wp-admin/comment.php.

See #52627.

[SergeyBiryukov]

In 51287:

Coding Standards: Add missing visibility keywords to WP_Theme, WP_Theme_JSON, and WP_Theme_JSON_Resolver tests.

Follow-up to [50959], [50960], [50967].

See #52627.

[SergeyBiryukov]

Reopening to merge [51287] to the 5.8 branch.

[desrosj]

In 51305:

Coding Standards: Add missing visibility keywords to WP_Theme, WP_Theme_JSON, and WP_Theme_JSON_Resolver tests.

Follow-up to [50959], [50960], [50967].

Props SergeyBiryukov.
Merges [51287] to the 5.8 branch.
Fixes #52627.

[SergeyBiryukov]

In 51400:

Bundled Themes: Correct comment formatting in inc/block-patterns.php.

Follow-up to [51045], [51103].

Props kapilpaul.
See #53359, #52627.

[SergeyBiryukov]

Reopening to merge [51400] to the 5.8 branch.

[desrosj]

In 51406:

Bundled Themes: Correct comment formatting in inc/block-patterns.php.

Follow-up to [51045], [51103].

Props kapilpaul, SergeyBiryukov.
See #53359, #52627.

[desrosj]

With the final RC due out tomorrow (RC3), today is the final day to consider any further adjustments for backporting.