Make WordPress Core

Opened 6 years ago

Closed 3 years ago

#52634 closed defect (bug) (worksforme)

Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js

Reported by: wp89mkt Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: 5.3
Severity: normal Keywords: reporter-feedback close
Cc: Focuses: javascript

Description

Twenty Twenty child theme, search modal on safari throws error in parent asset/index.js when search toggle clicked. Works fine in all other browsers.

TypeError: null is not an object (evaluating 'modal.querySelectorAll')

elements = modal.querySelectorAll( selectors );
null is not an object (evaluating 'modal.querySelectorAll')

Change History (6)

#1 @sabernhardt
6 years ago

  • Component General → Bundled Theme
  • Summary Twenty Twenty Child Theme Search Modal Safari Throws Error in Parent asset/index.js → Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js

#2 @sabernhardt
5 years ago

  • Focuses javascript added
  • Keywords reporter-feedback added
  • Version 5.6.2 → 5.3

Thanks for the report!

That line is in the keepFocusInModal function. Both search buttons should have the data-toggle-target=".search-modal" attribute, but it might help to know if this error occurs when clicking either the desktop or mobile search toggle button (or both).

#3 @karmatosed
3 years ago

@sabernhardt did you also get the error? I was unable to replicate using Safari so wondering if it isn't an issue now or I might be missing a step to reproduce.

#4 @sabernhardt
3 years ago

No, I did not test with Safari (if at all) years ago. I usually use Windows and have not booted up my old Mac to test this in the past few days either.

#5 @karmatosed
3 years ago

  • Keywords close added

Okay, I am unable to reproduce, so I recommend we close this with an option to reconsider if more information comes up. Thank you, everyone, for your collaboration so far.

#6 @karmatosed
3 years ago

  • Milestone Awaiting Review
  • Resolution → worksforme
  • Status new → closed

Thank you everyone for your collaboration, I am going to progress this to close now.

Note: See TracTickets for help on using tickets.