WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#52634 new defect (bug)

Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js

Reported by: wp89mkt's profile wp89mkt Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: reporter-feedback
Focuses: javascript Cc:

Description

Twenty Twenty child theme, search modal on safari throws error in parent asset/index.js when search toggle clicked. Works fine in all other browsers.

TypeError: null is not an object (evaluating 'modal.querySelectorAll')

elements = modal.querySelectorAll( selectors );
null is not an object (evaluating 'modal.querySelectorAll')

Change History (2)

#1 @sabernhardt
3 years ago

  • Component changed from General to Bundled Theme
  • Summary changed from Twenty Twenty Child Theme Search Modal Safari Throws Error in Parent asset/index.js to Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js

#2 @sabernhardt
2 years ago

  • Focuses javascript added
  • Keywords reporter-feedback added
  • Version changed from 5.6.2 to 5.3

Thanks for the report!

That line is in the keepFocusInModal function. Both search buttons should have the data-toggle-target=".search-modal" attribute, but it might help to know if this error occurs when clicking either the desktop or mobile search toggle button (or both).

Note: See TracTickets for help on using tickets.