Opened 6 years ago
Closed 3 years ago
#52634 closed defect (bug) (worksforme)
Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js
| Reported by: | wp89mkt | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Bundled Theme | Version: | 5.3 |
| Severity: | normal | Keywords: | reporter-feedback close |
| Cc: | Focuses: | javascript |
Description
Twenty Twenty child theme, search modal on safari throws error in parent asset/index.js when search toggle clicked. Works fine in all other browsers.
TypeError: null is not an object (evaluating 'modal.querySelectorAll')
elements = modal.querySelectorAll( selectors );
null is not an object (evaluating 'modal.querySelectorAll')
Change History (6)
#1
@
6 years ago
- Component General → Bundled Theme
- Summary Twenty Twenty Child Theme Search Modal Safari Throws Error in Parent asset/index.js → Twenty Twenty: Child Theme Search Modal Safari Throws Error in Parent asset/index.js
#3
@
3 years ago
@sabernhardt did you also get the error? I was unable to replicate using Safari so wondering if it isn't an issue now or I might be missing a step to reproduce.
#4
@
3 years ago
No, I did not test with Safari (if at all) years ago. I usually use Windows and have not booted up my old Mac to test this in the past few days either.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Thanks for the report!
That line is in the keepFocusInModal function. Both search buttons should have the
data-toggle-target=".search-modal"attribute, but it might help to know if this error occurs when clicking either the desktop or mobile search toggle button (or both).