Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#52643 closed defect (bug) (fixed)

Scope GitHub Action workflows to specific branches on `pull_request`

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: low
Severity: normal Version: 5.6
Component: Build/Test Tools Keywords: has-patch fixed-major
Focuses: Cc:


Some GHA workflows are not required in every branch. For example, the PHP Compatibility workflow was added in 5.5, and does not pass in previous branches.

The push trigger is already properly scoped to target branches and tags only matching push events >= 5.5. This needs to be copied over to the pull_request trigger as well.

This will prevent unnecessary workflows from running in older branches.

Attachments (1)

52643.diff (3.6 KB) - added by desrosj 3 years ago.

Download all attachments as: .zip

Change History (7)

3 years ago

#1 @desrosj
3 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 50432:

Build/Test Tools: Limit when GitHub Action workflows run on pull_request.

Different branches have support for different types of testing based on the tooling that was in place at the time each version was branched. The workflows currently in place have patterns configured to match the relevant branches and tags for each workflow, but only for push events.

This copies the patterns for matching supported branches over to the pull_request event to prevent workflows from running for a pull request to a branch that does not support that workflow.

Fixes #52643.

#2 @desrosj
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this to backport at some point.

#3 @desrosj
3 years ago

  • Version set to 5.6

This ticket was mentioned in Slack in #core by sergey. View the logs.

3 years ago

#5 @desrosj
3 years ago

In 50584:

Build/Test Tools: Backport several GitHub Action improvements and dependency updates.

This backports several GitHub Action improvements and devDependency updates to the 5.7 branch.

Backports [50432,50435-50436,50479,50485-50487,50545,50579] to the 5.7 branch.
See #52667, #52643, #52658, #52660, #52624, #52625.

#6 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This was included in [50602-50606].

This will be backported further next week, but going to close this out.

Note: See TracTickets for help on using tickets.