Context Navigation

← Previous Ticket
Next Ticket →

#52643 closed defect (bug) (fixed)

Scope GitHub Action workflows to specific branches on `pull_request`

Reported by:	desrosj	Owned by:	desrosj
Priority:	low	Milestone:	5.8
Component:	Build/Test Tools	Version:	5.6
Severity:	normal	Keywords:	has-patch fixed-major
Cc:		Focuses:

Description

Some GHA workflows are not required in every branch. For example, the PHP Compatibility workflow was added in 5.5, and does not pass in previous branches.

The push trigger is already properly scoped to target branches and tags only matching push events >= 5.5. This needs to be copied over to the pull_request trigger as well.

This will prevent unnecessary workflows from running in older branches.

Attachments (1)

52643.diff (3.6 KB ) - added by desrosj 5 years ago.

Download all attachments as: .zip

Change History (7)

@desrosj
5 years ago

Attachment 52643.diff added

#1 @desrosj
5 years ago

Owner set to desrosj
Resolution → fixed
Status new → closed

In 50432:

Build/Test Tools: Limit when GitHub Action workflows run on pull_request.

Different branches have support for different types of testing based on the tooling that was in place at the time each version was branched. The workflows currently in place have patterns configured to match the relevant branches and tags for each workflow, but only for push events.

This copies the patterns for matching supported branches over to the pull_request event to prevent workflows from running for a pull request to a branch that does not support that workflow.

Fixes #52643.

#2 @desrosj
5 years ago

Keywords fixed-major added
Resolution fixed
Status closed → reopened

Reopening this to backport at some point.

#3 @desrosj
5 years ago

Version → 5.6

This ticket was mentioned in Slack in #core by sergey. View the logs.

5 years ago

#5 @desrosj
5 years ago

In 50584:

Build/Test Tools: Backport several GitHub Action improvements and dependency updates.

This backports several GitHub Action improvements and devDependency updates to the 5.7 branch.

Backports [50432,50435-50436,50479,50485-50487,50545,50579] to the 5.7 branch.
See #52667, #52643, #52658, #52660, #52624, #52625.

#6 @desrosj
5 years ago

Resolution → fixed
Status reopened → closed

This was included in [50602-50606].

This will be backported further next week, but going to close this out.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#52643 closed defect (bug) (fixed)

Scope GitHub Action workflows to specific branches on `pull_request`

Description

Attachments (1)

Change History (7)

@desrosj 5 years ago

#1 @desrosj 5 years ago

#2 @desrosj 5 years ago

#3 @desrosj 5 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs. 5 years ago

#5 @desrosj 5 years ago

#6 @desrosj 5 years ago