Make WordPress Core

Opened 2 years ago

Last modified 14 months ago

#52683 reviewing defect (bug)

Twenty Twenty-One: Block "more" text in link can't be changed

Reported by: neokendev's profile neokendev Owned by: audrasjb's profile audrasjb
Milestone: Future Release Priority: normal
Severity: normal Version: 5.6.2
Component: Bundled Theme Keywords: has-patch dev-feedback needs-refresh
Focuses: Cc:


Hi team,
Hope you are well.
I am on basic theme 5.6.2

Quick TT about the block "more" that we can add in article to have the link read more on the home page.

When I add this block I can change the text of the link but for some reason it doesn't show up on home page. Doesn't matter what I change I have always "Poursuivre la lecture de" as a link on my home page. I am on french version.

I didn't find any fix on your doc.


Attachments (4)

wp2.PNG (37.6 KB) - added by neokendev 2 years ago.
wp.PNG (33.6 KB) - added by neokendev 2 years ago.
52683.diff (1.8 KB) - added by sabernhardt 17 months ago.
checking for user-defined "more" text in the_content_more_link, updating comments and docs
content-more-link-standard-and-custom.png (47.2 KB) - added by sabernhardt 17 months ago.

Download all attachments as: .zip

Change History (14)

2 years ago

2 years ago

#1 @neokendev
2 years ago

When I try with other version than 5.6.2 it's working well

#2 @neokendev
2 years ago

Sorry quick correction: wordpress version is 5.6.2
but theme is Twenty Twenty-One

#3 @sabernhardt
2 years ago

  • Component changed from Editor to Bundled Theme
  • Summary changed from Block "more" text in link can't be changed to Twenty Twenty-One: Block "more" text in link can't be changed

#4 @sabernhardt
2 years ago

There are a few issues here:

  1. Showing excerpts created by the "more" tag requires the "Full text" option for Twenty Twenty-One's Excerpt Settings, not the "Summary" setting. So if you use the more tag/block regularly, you will want to go to Customize > Excerpt Settings to switch to Full text.
  1. However, Twenty Twenty-One does not support my special more text, and I haven't figured out why not. The other bundled themes worked fine with it, though.
  1. Twenty Twenty-One's translator comment does not explain that the post title is visually hidden. (The comment currently is %s: Name of current post.; Twenty Nineteen's comment is %s: Post title. Only visible to screen readers.) I suggested a French translation without "de" before the post title, which will need to be approved or improved.
Last edited 17 months ago by sabernhardt (previous) (diff)

17 months ago

checking for user-defined "more" text in the_content_more_link, updating comments and docs

#5 @sabernhardt
17 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 6.0

I expect the patch needs some polishing, but it worked with my test.

#6 @audrasjb
15 months ago

Self assigning for review.

@sabernhardt thanks for the translation proposal, I approved the change on👌

#7 @audrasjb
15 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#8 @audrasjb
15 months ago

  • Keywords dev-feedback added

@sabernhardt I tested 52683.diff, but using "Summary" option on Excerpt settings, I doesn't show any link at all: I have a customized read more block on one post, and a normal post with a lot of text, and in both case I don't have any "more" link. Is it expected?

By the way, we can still commit the Translator string change since it's pretty confusing for translators. Maybe it's worth opening a new ticket for this change?

#9 @sabernhardt
15 months ago

@audrasjb Long posts should have a "Continue reading" link when blog and archive pages have the "Summary" Excerpt setting.

With Summary, the_excerpt creates a link only when truncating the post text. If the post content is shorter than the excerpt_length value (default 55 words), it does not create a link to continue reading.

But to get More link text specific to a post, that would only work with the Full text setting.

#10 @sabernhardt
14 months ago

  • Keywords needs-refresh added
  • Milestone changed from 6.0 to Future Release

The comment changes are in a separate ticket, #55564, to fix that now. This patch will need a refresh.

Note: See TracTickets for help on using tickets.