Changes between Version 2 and Version 3 of Ticket #52738, comment 17
- Timestamp:
- 07/02/2023 11:01:19 AM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #52738, comment 17
v2 v3 5 5 I've left a review on [https://github.com/WordPress/wordpress-develop/pull/3607 PR 3607] to tidy things up and meet Core standards/convention should it get support for inclusion in Core. Adding `changes-requested` to indicate the current status of the patch. 6 6 7 As @oglekler mentions, there are other instances of `get_object_vars()` in Core that haven't been changed to use `wp_get_object_vars()`. As the PR adds tests for each of the changed calls, we may either want to do everything at once, or follow up with additional patches to tackle the rest where applicable.7 If it does get support once additional Core developers have weighed in, then as @oglekler mentions, there are other instances of `get_object_vars()` in Core that haven't been changed to use `wp_get_object_vars()`. As the PR adds tests for each of the changed calls, we may either want to do everything at once, or follow up with additional patches to tackle the rest where applicable.