#52743 closed defect (bug) (fixed)
Hardcoded SVG image URLs on WP 5.7 About screen.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.7.1 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | Help/About | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description
Whereas the WP 5.7 About screen, as usual, offloads JPGs and MP4s to the wp.org CDN, 3 SVG images (/wp-admin/images/about-badge.svg
, /wp-admin/images/about-color-palette-vert.svg
, /wp-admin/images/about-color-palette.svg
) are embedded in the package.
However, these are loaded from hardcoded relative URLs (relative to wp-admin/about.php
when going to example.org/wp-admin/about.php
). Due to that, these images are not shown when accessing the About screen from the About screen in the Network Admin (i.e. via example.org/wp-admin/network/about.php
.
The hardcoded URLs should probably be replaced by calls to network_admin_url()
or similar.
Attachments (3)
Change History (11)
This ticket was mentioned in Slack in #core by sergey. View the logs.
4 years ago
#3
@
4 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to audrasjb
- Status changed from new to accepted
#4
follow-up:
↓ 5
@
4 years ago
It looks like this should be admin_url
, since network_admin_url
still adds the /network/ path to the URL. 52743.2.diff also fixes the issue in the other About subpages.
Should this be committed to trunk & backported to 5.7, or just committed to the 5.7 branch?
#5
in reply to:
↑ 4
@
4 years ago
Replying to ryelle:
It looks like this should be
admin_url
, sincenetwork_admin_url
still adds the /network/ path to the URL
Ah yes indeed 🤭 Thanks for pointing this out!
Should this be committed to trunk & backported to 5.7, or just committed to the 5.7 branch?
I think it's fine to commit to trunk then backport as is would fix the issue in trunk (trunk will show the 5.7 about page until the new about page is committed :)
about-badge.svg does not exist at example.org/wp-admin/network/images/about-badge.svg.