WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #52751, comment 6


Ignore:
Timestamp:
03/10/2021 08:28:53 PM (5 years ago)
Author:
palmiak
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #52751, comment 6

    initial v1  
    88
    99There is a chance that some other buttons will have the same problem, on some languages.
     10
     11EDIT:
     12the fix to CSS would look like this:
     13{{{#!css
     14.wp-core-ui .button,
     15.wp-core-ui .button-primary,
     16.wp-core-ui .button-secondary {
     17        display: inline-block;
     18        text-decoration: none;
     19        font-size: 13px;
     20        line-height: 1.5; /* 28px */
     21        min-height: 30px;
     22        margin: 0;
     23        padding: 0 10px;
     24        cursor: pointer;
     25        border-width: 1px;
     26        border-style: solid;
     27        -webkit-appearance: none;
     28        border-radius: 3px;
     29        white-space: normal;
     30        box-sizing: border-box;
     31}
     32
     33@media screen and (max-width: 782px) {
     34
     35        .wp-core-ui .button,
     36        .wp-core-ui .button.button-large,
     37        .wp-core-ui .button.button-small,
     38        input#publish,
     39        input#save-post,
     40        a.preview {
     41                padding: 0 14px;
     42                line-height: 1.5; /* 38px */
     43                font-size: 14px;
     44                vertical-align: middle;
     45                min-height: 40px;
     46                margin-bottom: 4px;
     47        }
     48
     49}}}
     50
     51I can't see any problems with such fix right now, but maybe this nowrap and big line-height was there for a reason.
     52
     53Also if we would change those - should we also remove nowrap from editor.css and jquery-ui-dialog.css