Opened 4 years ago
Closed 4 years ago
#52760 closed defect (bug) (fixed)
Color not accessibility for AA
Reported by: | Otshelnik-Fm | Owned by: | sabernhardt |
---|---|---|---|
Milestone: | 5.7.1 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | Administration | Keywords: | commit fixed-major |
Focuses: | accessibility, css | Cc: |
Attachments (9)
Change History (35)
#1
follow-up:
↓ 6
@
4 years ago
- Focuses css added
- Milestone changed from Awaiting Review to 5.7.1
- Owner set to sabernhardt
- Status changed from new to accepted
This ticket was mentioned in Slack in #core-css by sabernhardt. View the logs.
4 years ago
#3
@
4 years ago
- Keywords has-patch commit added
The patch looks good to me. The change is not super noticeable, but now it passes AA.
Thanks @sabernhardt, marking for commit
.
#6
in reply to:
↑ 1
@
4 years ago
Replying to sabernhardt:
We could check the other instances of
#787c82
Yes, please :) Upon a quick check, I've found quite a few other instances, would be great to make sure they meet the guidelines as well.
This ticket was mentioned in Slack in #core-css by sabernhardt. View the logs.
4 years ago
#8
@
4 years ago
- Keywords has-patch commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
For the remaining 58 instances of #787c82
, just over half of them are text that needs more contrast.
@ryelle made a good point about how darkening the icons could make a noticeable change in visual importance, so I only recommend editing 4 of those:
- The 3 search icons to keep them the same color as the placeholder text (in Customizer)
- The Themes filter icon to match the button's background color when the "drawer" of options is opened
(I didn't notice any icons that have insufficient contrast of less than 3.0 with this gray.)
#9
@
4 years ago
52760.1.diff adds more text color (and background color) changes, switching from the Gray 40 to Gray 50 again. I also included the theme tags list, which was even lighter.
#12
@
4 years ago
- Keywords commit fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.7 branch.
#14
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
While browsing my multisites I found out that the text on red background-color for an inactive website is not AA, in the website list.
Normal text: 3.03
Links: 2.13
Delete actions: 2.60
Pip character: 1.77
The same background-color can be seen in the user list, if a user is a member of an inactive website.
#15
@
4 years ago
Red 5
from Ryelle's color chart as background and Red 70
for delete actions make them comply to WCAG AA, but blue links don't.
Attached image shows one delete action link (Skräppost) in Red 70
, and background in Red 5
.
This ticket was mentioned in PR #1155 on WordPress/wordpress-develop by ryelle.
4 years ago
#17
- Keywords has-patch added; needs-patch removed
<img width="608" alt="1-invalid-nav" src="https://user-images.githubusercontent.com/541093/113353773-2aafff80-930c-11eb-9615-be004c3b530d.png">
<img width="423" alt="2-sites-status" src="https://user-images.githubusercontent.com/541093/113353775-2aafff80-930c-11eb-90dc-8e8cdff50f16.png">
Trac ticket: https://core.trac.wordpress.org/ticket/52760
#18
@
4 years ago
Rather than try to change all the link colors to get the blue link text to pass 4.5 contrast ratio against Red 5, I've tweaked how the site statuses are colored. In the PR above, I'm using Red 0 for both archive and deleted sites, and Yellow 0 for spammed and mature sites. This way we don't need to adjust the link colors, as both have 4.5+ contrast.
The other change in that PR is from doing a search of Red 5 as a background color, where I found that the menu type label on invalid nav items doesn't have enough contrast, so I've changed the background (lighter) & border (darker) to increase that contrast.
#20
@
4 years ago
The PR looks OK and it addresses the issues I found, thanks Ryelle!
I found another low contrast issue:
In widgets screen (and in the customizer), adding a plain text widget and switching to Text (from Visual) displays a “New Custom HTML Widget“-notice with 2.36 contrast ratio. White text on blue background.
4 years ago
#21
Updated the PR to address the other sections mentioned in the ticket. Now:
<img width="352" alt="Screen Shot 2021-04-06 at 1 19 05 PM" src="https://user-images.githubusercontent.com/541093/113752251-bd6ce780-96da-11eb-8c77-80f904516cd3.png">
<img width="231" alt="Screen Shot 2021-04-06 at 1 19 25 PM" src="https://user-images.githubusercontent.com/541093/113752252-be057e00-96da-11eb-9104-cb00b56f602d.png">
<img width="287" alt="Screen Shot 2021-04-06 at 12 19 24 PM" src="https://user-images.githubusercontent.com/541093/113752254-be057e00-96da-11eb-8026-e5856e3bcd70.png">
#22
@
4 years ago
- Keywords commit added
@ryelle The code changes and screen shots on the linked pull request look good to me. Are you able to do the commit honors during your day if you'd like to get it in prior to the release candidate? Thansk boss.
Thanks for the report!
The previous gray color for the dashboard activity widget's published dates was
#72777c
, which barely passed the guidelines at 4.52, but [50025] changed that to#787c82
(4.2:1 ratio).We could check the other instances of
#787c82
, and I'll create a preliminary patch to switch this text to the next-darkest gray in the palette (#646970
).The toolbar's comments link is an older issue, which can be addressed on #27831 (removing the link when there are zero comments to moderate instead of showing the number zero at half-opacity).