Theme Editor changes line endings of edited files

[diegoe]

If you have a theme, like twentyseventeen, that for whatever reason has CRLF newlines in its files, the Theme Editor will change the file format to regular unix newlines when saving.

This creates confusing diffs, since by default diff does *not* ignore the newline characters. You can work around that with diff --strip-trailing-cr, but it's a rather obscure bit of trivia, even if you "know enough" to be using diff.

I think the Theme Editor shouldn't change the file newline format of the edited files.

[sabernhardt]

Related/duplicate: #9716

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac!

Thanks for the ticket, sorry it took a while for someone to get back to you.

#9716 has a patch that should resolve this, so let's continue there.