Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#52776 closed defect (bug) (fixed)

Wrap long site title on login screen

Reported by: sumitsingh's profile sumitsingh Owned by: audrasjb's profile audrasjb
Milestone: 5.8 Priority: normal
Severity: minor Version: 5.7
Component: Login and Registration Keywords: has-screenshots has-patch commit
Focuses: css Cc:

Description

Hi,

I have just for mistake added long site title. and got overflow issue on WP login page. more information see mentioned screenshot.

Attachments (5)

Log In ‹ Produ.png (61.8 KB) - added by sumitsingh 4 years ago.
Issue screenshot
52776.diff (2.4 KB) - added by GeekPress 3 years ago.
Log In < Fixed.png (64.4 KB) - added by GeekPress 3 years ago.
52776-2.2.diff (277 bytes) - added by GeekPress 3 years ago.
login-long-password-underscores-chrome.png (5.0 KB) - added by sabernhardt 3 years ago.
with patch, in Windows/Chrome

Download all attachments as: .zip

Change History (14)

@sumitsingh
4 years ago

Issue screenshot

#1 follow-up: @audrasjb
4 years ago

  • Component changed from General to Login and Registration
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.8
  • Owner set to audrasjb
  • Severity changed from normal to minor
  • Status changed from new to accepted

Hi, thank you for pointing this out.
Looks like an edge case and a really minor issue but let's work on a fix. Probably our best bet is to specify a max-width for the container via CSS.

#2 in reply to: ↑ 1 ; follow-up: @sumitsingh
4 years ago

Hi @audrasjb ,

I know this is a minor issue. But my point of view shouldn't be any UI issues in WP (small issue). Also i have lot's of issue ticket created by why i am not getting Contribution History
batch in my profile?

Replying to audrasjb:

Hi, thank you for pointing this out.
Looks like an edge case and a really minor issue but let's work on a fix. Probably our best bet is to specify a max-width for the container via CSS.

#3 in reply to: ↑ 2 @audrasjb
4 years ago

I know this is a minor issue. But my point of view shouldn't be any UI issues in WP (small issue).

Yes, I previously moved it to milestone 5.8 so we're all good.

It would be nice to propose a patch for the issue. Thanks

#4 @SergeyBiryukov
4 years ago

  • Summary changed from wp-login page UI issue WordPress 5.7 running to Wrap long site title on login screen

#5 @GeekPress
3 years ago

I have attached a patch. It will result like on this screenshot: https://nsa40.casimages.com/img/2021/04/30/210430122419149360.png

Version 0, edited 3 years ago by GeekPress (next)

@GeekPress
3 years ago

@GeekPress
3 years ago

#6 @GeekPress
3 years ago

Sorry I have re-uploaded the patch. The first one was merged with a previous ticket :/

#7 @JeffPaul
3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

@sabernhardt
3 years ago

with patch, in Windows/Chrome

#8 @sabernhardt
3 years ago

  • Focuses css added
  • Keywords commit added; needs-testing removed

The break-word styling works in modern Windows browsers: Chrome, Firefox, Edge, Opera and Vivaldi. (It does not work for IE 11, but that's fine.)

#9 @ryelle
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51108:

Login and Registration: Wrap long site titles to a new line.

Props sumitsingh, geekpress, sabernhardt.
Fixes #52776.

Note: See TracTickets for help on using tickets.