Disable auto updates flag logic is reversed

[TimothyBlynJacobs]

#50824 introduced support for a disable_autoupdate flag to prevent an auto update from going thru, even if the user had opted into updates for that package via the UI.

​https://github.com/WordPress/wordpress-develop/blob/380d0445e84861ac0e634701d746b82634790f6f/src/wp-admin/includes/class-wp-automatic-updater.php#L177

It looks like, however, that the logic is reversed. If disable_autoupdate is set to a truthy value so it passed the ! empty check, that value will then be assigned to $update directly. Which would end up enabling auto updates for that package, even if the user hadn't opted in.

I think the fix would either be to negate the value of $item->disable_autoupdate, or perhaps more simply, set it to false.

[JeffPaul]

With 5.8 Beta 1 next week and no patch/PR on this ticket, I'm going to punt this to Future Release. Once a patch/PR is available this ticket can be added back to a numbered milestone.

[lopo]

@TimothyBlynJacobs do you know any plugin which currently has that flag set?

Straight forward fix (as suggested in the ticket description)

Trac ticket: https://core.trac.wordpress.org/ticket/52796

[benbornschein]

Why is this still not fixed? The flag is in its current state useless.

[TimothyBlynJacobs]

In 58285:

Upgrade: Fix the disable_autoupdate flag logic.

In #50824 support was added for a package to include a disable_autoupdate flag to indicate that the plugin/theme should not be auto-updated even if a user had opted-in via the WP-Admin UI. However, the logic implementing the flag was inverted.

This commit repairs the logic. If a package has disable_autoupdate set, then it should not be auto-updated.

Props amisiewicz.
Fixes #52796.

Merged in 58285. Thanks for the patch!