#52813 closed enhancement (fixed)
Pass the scheme to all the `*_url` filters
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch commit needs-dev-note |
Focuses: | Cc: |
Description
The following filters miss the $scheme
parameter that's present in the other URL related filters.
admin_url
includes_url
network_admin_url
user_admin_url
Attachments (2)
Change History (7)
#1
@
4 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 5.8
#3
@
4 years ago
- Keywords commit added
52813.2.diff adjusts the @param
tags to indicate default values.
Note: See
TracTickets for help on using
tickets.
52813.diff looks good to me. I think it would be beneficial to document the default value to be more clear, though.
For example, the default scheme for
admin_url
,network_admin_url
, anduser_admin_url
isadmin
(which obeys which obeysforce_ssl_admin()
andis_ssl()
), butincludes_url
uses anull
default.