WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 3 weeks ago

#52813 new enhancement

Pass the scheme to all the `*_url` filters

Reported by: johnbillion Owned by:
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

The following filters miss the $scheme parameter that's present in the other URL related filters.

  • admin_url
  • includes_url
  • network_admin_url
  • user_admin_url

Attachments (1)

52813.diff (3.7 KB) - added by johnbillion 2 months ago.

Download all attachments as: .zip

Change History (3)

@johnbillion
2 months ago

#1 @johnbillion
2 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.8

#2 @desrosj
3 weeks ago

52813.diff looks good to me. I think it would be beneficial to document the default value to be more clear, though.

For example, the default scheme for admin_url, network_admin_url, and user_admin_url is admin (which obeys which obeys force_ssl_admin() and is_ssl()), but includes_url uses a null default.

Note: See TracTickets for help on using tickets.