Post metabox style Twenty Seventeen has a border

[joseeyoast]

In Twenty Seventeen the post metabox/editor styling looks incorrect, it has a border between them. It looks fine in Twenty Twenty-One.

[joseeyoast]

Twenty Seventeen post metabox

[joseeyoast]

Twenty Twenty-One post metabox

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the report.

A similar issue was fixed in #52646 for Twenty Fifteen and Twenty Sixteen. But it looks like Twenty Seventeen was missed in testing, I don't see it mentioned in comment:4:ticket:52646.

Moving to 5.7.1 to apply the fix to Twenty Seventeen as well.

[audrasjb]

Twenty Seventeen: Remove extra space around post editor.

[audrasjb]

Before patch

[audrasjb]

After 52816.diff

[audrasjb]

Step to reproduce the issue:

• Install Twenty Seventeen
• Add the following code to the theme’s functions.php file
• Go the post editor

function wporg_add_custom_box() {
    $screens = [ 'post', 'wporg_cpt' ];
    foreach ( $screens as $screen ) {
        add_meta_box(
            'wporg_box_id',
            'Custom Meta Box Title',
            'wporg_custom_box_html',
            $screen
        );
    }
}
add_action( 'add_meta_boxes', 'wporg_add_custom_box' );

function wporg_custom_box_html( $post ) {
    ?>
    <p>
        <label for="wporg_field">Description for this field</label><br />
	<input type="text" value="My value" />
    </p>
    <?php
}

[SergeyBiryukov]

In 50534:

Twenty Seventeen: Remove extra space around post editor.

The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb.
Fixes #52816.

[SergeyBiryukov]

Reopening for backporting to the 5.7 branch.

[peterwilsoncc]

In 50588:

Twenty Seventeen: Remove extra space around post editor.

The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb, SergeyBiryukov.
Merges [50534] to the 5.7 branch.
Fixes #52816.