Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#52846 closed enhancement (fixed)

Revisit the bundled block patterns

Reported by: onemaggie's profile onemaggie Owned by: youknowriad's profile youknowriad
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

It would be a good idea to revisit the current bundled block patterns. There has been some discussion on this ticket about the design for those and I'm opening this issue to include them.

cc @melchoyce @kjellr @beafialho

Attachments (1)

new-patterns.png (2.6 MB) - added by melchoyce 3 years ago.
All of the new patterns being added. Screenshot from Twenty Twenty-One.

Change History (12)

This ticket was mentioned in PR #1103 on WordPress/wordpress-develop by MaggieCabrera.


3 years ago
#1

  • Keywords has-patch added

This is a follow-up on https://github.com/WordPress/gutenberg/issues/28921 since I discussed with Kjell that this would be better living in core with the rest of the patterns. Follow the discussion on the linked Gutenberg issue for all the details on these patterns. Please Kjell let me know if I should change the wording on the descriptions and titles of these patterns, as well as the categories if the patterns should be organized in a different way.

In order to ensure these patterns will work correctly on any theme, I tested them using Empty Theme, which adds no block CSS and no custom colors to the editor.

Trac ticket: https://core.trac.wordpress.org/ticket/52846

#2 @onemaggie
3 years ago

  • Keywords has-patch removed

Please @kjellr let me know if I should change the wording on the descriptions and titles of these patterns, as well as the categories if the patterns should be organized in a different way.

In order to ensure these patterns will work correctly on any theme, I tested them using Empty Theme, which adds no block CSS and no custom colors to the editor.

#3 @onemaggie
3 years ago

  • Keywords has-patch added

#4 @kjellr
3 years ago

  • Milestone changed from Awaiting Review to 5.8

@melchoyce
3 years ago

All of the new patterns being added. Screenshot from Twenty Twenty-One.

youknowriad commented on PR #1103:


3 years ago
#5

Is this patch up to date with what has been merged in Gutenberg?

Can we get the phpcs issues fixed?

MaggieCabrera commented on PR #1103:


3 years ago
#6

Is this patch up to date with what has been merged in Gutenberg?

Can we get the phpcs issues fixed?

It is not! I will get to it tomorrow and be sure that the format is correct

MaggieCabrera commented on PR #1103:


3 years ago
#7

@youknowriad I just updated this with the latest from trunk in Gutenberg. Composer format didn't bring any errors for me.

#8 @youknowriad
3 years ago

This is looking good to me..

#9 @youknowriad
3 years ago

  • Owner set to youknowriad
  • Resolution set to fixed
  • Status changed from new to closed

In 50794:

Block Editor: Update the bundled block patterns.

This updates the block patterns included by default on WordPress
to give them more personality and to make use of the design tools
that has been added to the editor.

Props onemaggie, melchoyce, kjellr, beafialho, gziolo.
Fixes #52846.

ryelle commented on PR #1103:


3 years ago
#10

Committed in r50794.

#11 @desrosj
3 years ago

In 51133:

Upgrade/Install: Update the $_old_files list for 5.8.

Follow up to [50761], [50794], [51021].
Props kapilpaul, desrosj.
See #52991, #52846, #53246.
Fixes #53367.

Note: See TracTickets for help on using tickets.