Make WordPress Core

Opened 10 months ago

Closed 8 months ago

Last modified 7 months ago

#52852 closed enhancement (fixed)

Update Twemoji for 5.8

Reported by: desrosj Owned by: desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: has-patch has-unit-tests
Focuses: Cc:

Description (last modified by desrosj)

A new version of Twemoji, v13.0.2 is now available.

This is a minor update that does not introduce any new Emoji, but instead fixes and refines 14 preexisting ones.

Here is a summary of some changes:

  • Cricket: the colors have been adjusted to improve readability on small screens and to prevent confusion with other Emoji that had a similar color.
  • T-Rex: The color and posture of the T-Rex has been adjusted.
  • Portuguese flag: A line within the flag's circle has been corrected.
  • Thai flag: The proportions of the stripes for this flag have been corrected.
  • Fox face: The symmetry has been improved.
  • Transgender flag: The lines have been updated to prevent small gaps between stripes from showing when rendered with antialiasing.
  • Rolling on the floor laughing: Adjusted to be less exaggerated and appear more natural.

Since no source code changes will result from updating the library's version in package.json and the meanings of the Emoji have not been altered, the current 13.0.1 folder on the CDN can be updated with the latest versions. All users for sites running WordPress 5.6 or higher will see the new Emoji immediately, or when the caching for the respective files expires.

Previously: #51356, #50148, #48293.

Attachments (3)

before (13.0.1).png (100.9 KB) - added by desrosj 10 months ago.
after (13.0.2).png (101.3 KB) - added by desrosj 10 months ago.
52852.diff (1.1 KB) - added by desrosj 10 months ago.

Download all attachments as: .zip

Change History (20)

#1 @desrosj
10 months ago

  • Description modified (diff)

#2 @desrosj
10 months ago

  • Keywords has-patch has-screenshots added

10 months ago

#3 @desrosj
10 months ago

In 50548:

Emoji: Update the Twemoji library to version 13.0.2.

This point release does not add any new Emoji and only slightly modifies 14 existing Emoji without changing their meanings.

Because of this, the same CDN location (currently /images/core/emoji/13.0.1) can be updated with the new versions and sites running WordPress 5.6 or higher will start using the updated versions once their cache expires.

See #52852.

#4 @desrosj
10 months ago

@Otto42 would you be able to update the CDN versions on .org? The latest versions are here: https://github.com/twitter/twemoji/releases/tag/v13.0.2.

This would be similar to the update in [dotorg:15520] for #48293.

#5 @Otto42
10 months ago

@desrosj So, do we want to introduce a 13.0.2 directory for these, or just update the existing 13.0.1 directory with the new icons?

#6 @desrosj
10 months ago

Let's just continue using the current 13.0.1 folder please!

Since no changes are required in the Core code base, this will allow us to push the update out to everyone right away (no need to wait for 5.8).

#7 @Otto42
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Files updated in [dotorg:17102].

Files modified:


#8 @kraftbj
8 months ago

  • Keywords has-patch has-screenshots removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Twemoji has released version 13.1.0, which has a few new emoji. See https://github.com/twitter/twemoji/releases/tag/v13.1.0

tl;dr: Various bearded figure modifications (neutral, man, woman bearded options), a lot of variations of skin tones + people kissing, with five totally new emoji (heart on fire, bandaged heart, face with spiral eyes, face in clouds, face exhaling.

What do y'all think about continuing to use the 13.0.1 folder or switching to a new 13.1.0? In 13.0.2, we kept the same dir even though the syringe emoji changed a fair amount (blood vs empty, to align with what the other vendors are doing to make the emoji character work for vaccines too).

With that change, I would think a new folder (and the patch acts as such).

This ticket was mentioned in PR #1314 on WordPress/wordpress-develop by kraftbj.

8 months ago

  • Keywords has-patch has-unit-tests added
  • Update to Twemoji 13.1.0
  • Update detection script

Twitter has released a new version of Twemoji. Let's update our version.

Trac ticket: https://core.trac.wordpress.org/ticket/52852

#10 @kraftbj
8 months ago

Aside: I'm not sure if this counts as a feature change (and thus too late for 5.8) or not. If it's too late for 5.8, just let me know and I'll re-open a 5.9 Twemoji ticket.

#11 @desrosj
8 months ago

  • Keywords commit added

What do y'all think about continuing to use the 13.0.1 folder or switching to a new 13.1.0?

I think it may be best to introduce a new 13.1.0 folder on the CDN. While the syringe did change quite a bit, I felt it was OK to push out because, in my opinion, it would have a potentially positive impact.

That said, all of the other updates in 13.0.2 were relatively minor, and no new Emoji were introduced. Any time new emoji are introduced, it's probably best to have a new folder.

Aside: I'm not sure if this counts as a feature change (and thus too late for 5.8) or not.

There are probably sensible arguments for both sides of this. I think it's reasonable to include this update. The messaging would become pretty confusing if we need to say "Twemoji was updated, but only to 13.0.2, and 13.1.0 will be included in the next release." It's more clear to just say "updated to the latest version."

Also, since we're creating a new folder on the CDN, it won't be possible to push further minor refinements (should they happen) to users until 5.9 is released if this update is not included.

Your PR looks good to me @kraftbj! Happy to commit it once we're able to push the new folder to the CDN.

#12 @desrosj
8 months ago

  • Keywords commit removed

Just noting that latest 13.1.0 version of Twemoji was committed in [dotor:17419] and pushed to the CDN. Props @Otto42 for that.

In my pre-commit testing of this, I'm not seeing the new emoji being loaded properly. I haven't had a chance to dig deeper, but the files are accessible on the CDN. The front end replacement is just not happening.

Version 0, edited 8 months ago by desrosj (next)

#13 @kraftbj
8 months ago

@desrosj -- I'll look into it too. What operating system are you using? The replacement won't occur if your OS already supports it. macOS added this in 11.3 per https://www.theverge.com/2021/4/26/22404124/mac-macos-update-11-3-security-ios-app-m1-gaming-controller-music

#14 @desrosj
8 months ago

Ah! I think I found what the issue was.

In the JavaScript to detect whether newer Emoji are supported, the characters in the first set were incorrect. They were listed as 0xD83C, 0xDD25, which actually corresponds to the parenthesized Latin capital letter V.

The fire emoji is 0xD83D, 0xDD25, which was changed in set2 but not set1. The 0xD83C was the first character of the baby bottle Emoji (0xD83C, 0xDF7C) used in the last version. I think that was just missed in the PR attached. I've pushed this change to the PR to verify with the tests.

@kraftbj could you give the updated PR some testing today?

#15 @kraftbj
8 months ago

@desrosj Thanks for catching that. It was, indeed, me testing out the patch without having everything committed. With your commit, it is rendering it like I'd expect.

#16 @desrosj
8 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from reopened to closed

In 51113:

Emoji: Update the Twemoji library to version 13.1.0.

This version introduces support for the latest Emoji added in version Emoji 13.1, which includes “face in clouds”, “face exhaling”, and of course, “face with spiral eyes”.

A new corresponding folder has been pushed to WordPress.org in [dotorg:17419].

Rages deep within, ❤️‍🔥.

Props kraftbj., desrosj.
Fixes #52852.

#17 @prbot
7 months ago

kraftbj commented on PR #1314:

This has landed. Closing.

Note: See TracTickets for help on using tickets.