WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52861 closed defect (bug) (fixed)

Settings: Add two cities to wp-admin/includes/continents-cities.php

Reported by: wangql's profile wangql Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.7
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

There are two cities listed in timezone settings in Settings General screen but with no translations: Nuuk and Qostanay.

Files affected: wp-admin/includes/continents-cities.php

Attachments (5)

continents-cities.php​ (20.3 KB) - added by wangql 4 years ago.
continents-cities.2.php​ (20.3 KB) - added by wangql 4 years ago.
52861.diff​ (898 bytes) - added by mukesh27 4 years ago.
52861.2.diff​ (898 bytes) - added by wangql 4 years ago.
1107.diff​ (788 bytes) - added by wangql 4 years ago.

Download all attachments as: .zip

Change History (15)

@wangql
4 years ago

#1 @wangql
4 years ago

  • Summary changed from Add two cities to wp-admin/includes/continents-cities.php to Settings: Add two cities to wp-admin/includes/continents-cities.php

#2 @wangql
4 years ago

  • Component changed from General to Date/Time

This ticket was mentioned in ​PR #1107 on ​WordPress/wordpress-develop by ​wangql-wp.
4 years ago #3

There are two cities listed in timezone settings in Settings General screen but with no translations: Nuuk and Qostanay.

Trac ticket: https://core.trac.wordpress.org/ticket/52861

@wangql
4 years ago

#4 @mukesh27
4 years ago

  • Component changed from Date/Time to I18N

@mukesh27
4 years ago

@wangql
4 years ago

@wangql
4 years ago

#5 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.8
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
4 years ago

In 50554:

I18N: Remove duplicate entries from the list of continents and cities.

Follow-up to [37554].

See #52861.

#7 @SergeyBiryukov
4 years ago

Hi there, welcome back to WordPress Trac! Thanks for the ticket and the patch.

Just confirming that per the current timezone_identifiers_list() output on PHP 8.0.3, Nuuk and Qostanay are indeed the only two cities missing from the translations list.

#8 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50555:

I18N: Update list of continents and cities for the timezone selection.

Props wangql, mukesh27.
Fixes #52861.

​wangql-wp commented on ​PR #1107:
4 years ago #9

Fixed in trac.

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
4 years ago

Note: See TracTickets for help on using tickets.