Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#52869 new enhancement

Twenty Twenty-One: Text isn't vertically centered to the checkbox

Reported by: ooker's profile ooker Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: reporter-feedback
Focuses: css Cc:

Description

I think we should add vertical-align: middle; into the line 1344 to have text aligning centerally vertically to the checkbox. Currently the code is like this:

@supports (-webkit-appearance: none) or (-moz-appearance: none) {

	input[type=checkbox],
	input[type=radio] {
		-webkit-appearance: none;
		-moz-appearance: none;
		position: relative;
		width: 25px;
		height: 25px;
		border: var(--form--border-width) solid var(--form--border-color);
		background: var(--global--color-white);
	}

Change History (4)

#1 @peterwilsoncc
3 years ago

  • Component changed from Formatting to Bundled Theme
  • Keywords has-screenshots removed
  • Version changed from 5.7 to 5.6

Hi @ooker and welcome back to trac!

I notice you included the has-screenshots keyword, did you intend to attach an image to the ticket?

#2 @justinahinon
3 years ago

  • Keywords reporter-feedback added

Hello @ooker,

I can not reproduce the output on your screenshot. The checkboxes are correctly aligned for me (see screenshot https://cln.sh/VfGtXv).

Maybe there's another plugin interfering with this element style?

Can you confirm you still have the same behavior on a fresh WordPress installation with no plugin activated?

#3 @ooker
3 years ago

It turns out that only checkboxes produced by the plugin Formidable Form has this problem. But the problem is forms from that plugin can inherit styles from the theme by disable custom styling. It seems that other themes don't have this problem (or else the plugin author should have fixed it).

Anyhow, would there be any problem to add vertical-align: middle; into the line 1344? It may fixed future bugs as well.

Note: See TracTickets for help on using tickets.