Make WordPress Core

Opened 3 years ago

Last modified 14 months ago

#52871 new enhancement

Space added after the "option" tag on the options-writing.php file

Reported by: laxman-prajapati's profile Laxman Prajapati Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch close 2nd-opinion
Focuses: coding-standards Cc:

Description

Space added after the "option" tag on the options-writing.php file as a standard workflow.

Attachments (1)

52871.patch (868 bytes) - added by Laxman Prajapati 3 years ago.
Created patch.

Download all attachments as: .zip

Change History (7)

@Laxman Prajapati
3 years ago

Created patch.

#1 @Laxman Prajapati
3 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 years ago

  • Component changed from Customize to Administration

#3 @knutsp
3 years ago

  • Version 5.7 deleted

The selected() function returns the attribute with a preceding space, so this will just result in a double space, both with and without the attribute.

#4 follow-up: @iluy
3 years ago

Hello everyone, for the first time, I'm trying to work through some tickets following this guide: https://make.wordpress.org/core/handbook/testing/bug-gardening/#3-confirm-the-patch

And I believe "the priority or milestone should be adjusted" for this ticket :)

(I followed steps 1 to 4 of the above guide)

#5 in reply to: ↑ 4 @iluy
3 years ago

As per the descriptions given in this part of the core handbook https://make.wordpress.org/core/handbook/contribute/trac/#ticket-properties , I now believe this ticket should be made an "enhancement" and not a "defect(bug)"

If anyone could confirm this it would help me as I learn my way through the WP contributor process, :) Cheers!

Replying to iluy:

Hello everyone, for the first time, I'm trying to work through some tickets following this guide: https://make.wordpress.org/core/handbook/testing/bug-gardening/#3-confirm-the-patch

And I believe "the priority or milestone should be adjusted" for this ticket :)

(I followed steps 1 to 4 of the above guide)

#6 @SergeyBiryukov
14 months ago

  • Keywords close 2nd-opinion added
  • Type changed from defect (bug) to enhancement

Ho there, thanks for the ticket!

As noted in comment:3, the selected() function includes a preceding space, so there is no bug here.

There are a few other instances of <option<?php selected( ... ); ?> ... > in core, so there does not seem to be a need to change this particular instance.

That said, it could be considered a minor readability improvement, so I'm curious to see what others think.

Note: See TracTickets for help on using tickets.