WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 2 weeks ago

#52871 new defect (bug)

Space added after the "option" tag on the options-writing.php file

Reported by: Laxman Prajapati Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: coding-standards Cc:

Description

Space added after the "option" tag on the options-writing.php file as a standard workflow.

Attachments (1)

52871.patch (868 bytes) - added by Laxman Prajapati 7 months ago.
Created patch.

Download all attachments as: .zip

Change History (6)

@Laxman Prajapati
7 months ago

Created patch.

#1 @Laxman Prajapati
7 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 months ago

  • Component changed from Customize to Administration

#3 @knutsp
7 months ago

  • Version 5.7 deleted

The selected() function returns the attribute with a preceding space, so this will just result in a double space, both with and without the attribute.

#4 follow-up: @iluy
2 weeks ago

Hello everyone, for the first time, I'm trying to work through some tickets following this guide: https://make.wordpress.org/core/handbook/testing/bug-gardening/#3-confirm-the-patch

And I believe "the priority or milestone should be adjusted" for this ticket :)

(I followed steps 1 to 4 of the above guide)

#5 in reply to: ↑ 4 @iluy
2 weeks ago

As per the descriptions given in this part of the core handbook https://make.wordpress.org/core/handbook/contribute/trac/#ticket-properties , I now believe this ticket should be made an "enhancement" and not a "defect(bug)"

If anyone could confirm this it would help me as I learn my way through the WP contributor process, :) Cheers!

Replying to iluy:

Hello everyone, for the first time, I'm trying to work through some tickets following this guide: https://make.wordpress.org/core/handbook/testing/bug-gardening/#3-confirm-the-patch

And I believe "the priority or milestone should be adjusted" for this ticket :)

(I followed steps 1 to 4 of the above guide)

Note: See TracTickets for help on using tickets.