get_term_link() WARNING

[Tkama]

$rewrite parameter for the register_taxonomy() function can be set as false. Doing so we get such WARNING

​https://prnt.sc/10sfqew

​https://prnt.sc/10sfr2d

[SergeyBiryukov]

Hi there, thanks for the report and the patch.

I was able to reproduce the issue, but only when the taxonomy also has a custom permalink structure, either by calling add_permastruct() or using the pre_term_link filter. By default, add_permastruct() is only called for a taxonomy if the `rewrite` argument is not false​, which is the opposite of what's being reported here.

Otherwise, the $wp_rewrite->get_extra_permastruct()​ call a few lines above returns false and the control gets into the first conditional branch​, and not the one that causes the warning.

52882.diff​ includes a unit test.

This is not new in 5.7 and appears to be introduced in [15824], adjusting the version accordingly.

[SergeyBiryukov]

In 50565:

Taxonomy: Use a consistent check for the $rewrite['hierarchical'] parameter.

This avoids a "Trying to access array offset on value of type bool" PHP warning in get_term_link() if the $rewrite parameter of register_taxonomy() is set as false.

Props Tkama, SergeyBiryukov.
Fixes #52882.