Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 12 months ago

#52905 closed enhancement (fixed)

Add e2e tests for Quick Draft section in Dashboard

Reported by: isabel_brison's profile isabel_brison Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: coding-standards Cc:

Description

Splitting off a task from #52895.

Change History (10)

This ticket was mentioned in PR #1122 on WordPress/wordpress-develop by tellthemachines.


3 years ago
#1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/52905

Adds some tests for Quick Draft section in Dashboard.

I named the file "Dashboard" because we might think of other things to test on that page, and it seems right to separate tests by admin pages as they mostly have distinct types of functionality.

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.8

#3 @johnbillion
3 years ago

The first two tests here (for creating drafts) look solid and I think they should go in. The third test seems too fragile to me as it relies heavily on four consecutive page reloads happening within 500ms, and the value of that test is much lower.

I'd be in favour of committing the first two as they add value, but leaving the third test out to avoid a low value and fragile test.

#4 @isabel_brison
3 years ago

Thanks for the review @johnbillion ! Any action needed on my side?

#5 @desrosj
3 years ago

  • Owner set to desrosj
  • Status changed from new to assigned

#6 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

This was fixed in [51128].

tellthemachines commented on PR #1122:


3 years ago
#7

Closing as this was committed in https://core.trac.wordpress.org/changeset/51128

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


21 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


21 months ago

This ticket was mentioned in Slack in #core-committers by mike. View the logs.


12 months ago

Note: See TracTickets for help on using tickets.