WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 7 months ago

Last modified 6 months ago

#52905 closed enhancement (fixed)

Add e2e tests for Quick Draft section in Dashboard

Reported by: isabel_brison Owned by: desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: coding-standards Cc:

Description

Splitting off a task from #52895.

Change History (7)

This ticket was mentioned in ​PR #1122 on ​WordPress/wordpress-develop by ​tellthemachines.
10 months ago

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/52905

Adds some tests for Quick Draft section in Dashboard.

I named the file "Dashboard" because we might think of other things to test on that page, and it seems right to separate tests by admin pages as they mostly have distinct types of functionality.

#2 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 5.8

#3 @johnbillion
8 months ago

The first two tests here (for creating drafts) look solid and I think they should go in. The third test seems too fragile to me as it relies heavily on four consecutive page reloads happening within 500ms, and the value of that test is much lower.

I'd be in favour of committing the first two as they add value, but leaving the third test out to avoid a low value and fragile test.

#4 @isabel_brison
8 months ago

Thanks for the review @johnbillion ! Any action needed on my side?

#5 @desrosj
7 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

#6 @desrosj
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

This was fixed in [51128].

Note: See TracTickets for help on using tickets.