WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 7 weeks ago

#52970 new defect (bug)

Improve text in help tabs of Personal Data Exporter/Eraser

Reported by: dimadin Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.7
Component: Help/About Keywords: has-patch needs-copy-review needs-privacy-review
Focuses: privacy Cc:

Description

In #43994, it was proposed to add help tabs to Personal Data Exporter/Eraser tools. They were added in [50147] based on proposal by @burtrw. However, text that was committed gives incorrect information and it's inconsistent.

The biggest issue is that it gives false information about what data is deleted/anonymized by default. The only thing that is actually deleted/anonymized is the data about author of the comment user has made. My patch makes the following changes:

  • Only lists things that eraser actually does.
  • Reviews listing of things that are exported, and uses names that are used in an export file.
  • Uses sentence case for listing.
  • Appends "Personal" in front of "Data Exporter/Eraser".

Exporter: BEFORE | AFTER
Eraser: BEFORE | AFTER

Change History (14)

#2 @SergeyBiryukov
4 months ago

  • Keywords needs-privacy-review added
  • Milestone changed from Awaiting Review to 5.7.1

#3 @prbot
4 months ago

dimadin commented on PR #1166:

To clarify, I didn't expect changes to be included in 5.7.1, but your proposal makes sense: delete the inaccurate text without introducing new string, while the rest will land in 5.8.

If we are going that route, please let me know how should I update PR. I guess new PR for the text that would be deleted, then refreshing this one for other changes?

#4 @dimadin
4 months ago

This was reply to the following comment on GitHub:

Is it possible to limit the changes for 5.7.1 to deleting the inaccurate text in src/wp-admin/erase-personal-data.php only?

While the proposed text changes improve clarity, I am not sure they are currently unclear enough to require immediate string changes and the associated translation updates needed.

Not sure if this is intended behavior, but looks like comments left during PR review aren't copied here.

This ticket was mentioned in PR #1174 on WordPress/wordpress-develop by peterwilsoncc.


4 months ago

https://core.trac.wordpress.org/ticket/52970

5.7.1 change without new strings.

#6 @peterwilsoncc
4 months ago

@dimadin I've created a new pull request that only deletes the incorrect strings. Are you able to review it and make sure I've got everything correct?

I would have expected more data was deleted but given I am neither a lawyer or European my understanding of GDPR requirements is rudimentary at best :)

#7 @dimadin
4 months ago

Done.

For a reference, this is the only eraser used in WordPress core.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


4 months ago

#9 @audrasjb
4 months ago

  • Milestone changed from 5.7.1 to 5.8

Moving to Milestone 5.8 as WordPress 5.7.1 Release Candidate 1 is planned for today.

This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.


4 months ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


4 months ago

#12 @desrosj
2 months ago

  • Type changed from enhancement to defect (bug)

Today is feature freeze for the 5.8 release. But, I think it's reasonable to consider this a bug since the text is inaccurate. Reclassifying as such.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 weeks ago

#14 @JeffPaul
7 weeks ago

  • Milestone changed from 5.8 to 5.9

While this appears near ready to commit, we're minutes away from 5.8 Beta 1 so I'm sadly inclined to punt this to 5.9 to land then.

Note: See TracTickets for help on using tickets.