Opened 3 years ago
Closed 3 years ago
#52988 closed task (blessed) (fixed)
Add/improvement tests for Link/Bookmark API functions
Reported by: | hellofromTonya | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
Source: wp-includes/bookmark.php
With the goal to improve test coverage for Link/Bookmark API, this ticket
- adds missing function tests
- improves existing
get_bookmarks
tests (including adding unhappy paths and refactoring to data providers where appropriate)
Change History (13)
This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.
3 years ago
This ticket was mentioned in PR #1180 on WordPress/wordpress-develop by hellofromtonya.
3 years ago
#2
- Keywords has-patch has-unit-tests added; needs-unit-tests removed
#3
@
3 years ago
- Milestone changed from Awaiting Review to 5.8
Moving into 5.8, though not specifically related to a specific release itself.
This ticket was mentioned in Slack in #core-php by hellofromtonya. View the logs.
3 years ago
This ticket was mentioned in Slack in #core-php by hellofromtonya. View the logs.
3 years ago
hellofromtonya commented on PR #1180:
3 years ago
#6
It looks like there was an accidental change to package-lock.json included in 3111683 but I'll preapprove as it's really the committers responsibility to check against these things.
Yup, I did. Doh. Way too easy to accidentally commit lock file. Luckily, it's straightforward for the core committer to skip over that file and only commit the test file.
Thanks @peterwilsoncc!
#9
@
3 years ago
@hellofromTonya I've committed the get_bookmark()
tests in [50789]. I've left the ticket open for now as your description suggests you wish to add further tests.
peterwilsoncc commented on PR #1180:
3 years ago
#10
Committed as https://core.trac.wordpress.org/changeset/50789
Trac ticket: https://core.trac.wordpress.org/ticket/52988
Adds unit tests for
get_bookmark()
.