Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#52988 closed task (blessed) (fixed)

Add/improvement tests for Link/Bookmark API functions

Reported by: hellofromTonya Owned by: hellofromTonya
Priority: normal Milestone: 5.9
Component: Build/Test Tools Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Source: wp-includes/bookmark.php

With the goal to improve test coverage for Link/Bookmark API, this ticket

  • adds missing function tests
  • improves existing get_bookmarks tests (including adding unhappy paths and refactoring to data providers where appropriate)

Change History (13)

This ticket was mentioned in ​Slack in #core-test by hellofromtonya. ​View the logs.


6 years ago

This ticket was mentioned in ​PR #1180 on ​WordPress/wordpress-develop by ​hellofromtonya.


6 years ago
#2

  • Keywords has-patch has-unit-tests added; needs-unit-tests removed

Trac ticket: https://core.trac.wordpress.org/ticket/52988

Adds unit tests for get_bookmark().

#3 @hellofromTonya
5 years ago

  • Milestone Awaiting Review → 5.8

Moving into 5.8, though not specifically related to a specific release itself.

This ticket was mentioned in ​Slack in #core-php by hellofromtonya. ​View the logs.


5 years ago

This ticket was mentioned in ​Slack in #core-php by hellofromtonya. ​View the logs.


5 years ago

​hellofromtonya commented on ​PR #1180:


5 years ago
#6

It looks like there was an accidental change to package-lock.json included in 3111683 but I'll preapprove as it's really the committers responsibility to check against these things.

Yup, I did. Doh. Way too easy to accidentally commit lock file. Luckily, it's straightforward for the core committer to skip over that file and only commit the test file.

Thanks @peterwilsoncc!

#7 @peterwilsoncc
5 years ago

  • Component General → Build/Test Tools

#8 @peterwilsoncc
5 years ago

In 50789:

Build/Tests tools: Improve get_bookmark() test coverage.

Props hellofromtonya, peterwilsoncc.
See #52988.

#9 @peterwilsoncc
5 years ago

@hellofromTonya I've committed the get_bookmark() tests in [50789]. I've left the ticket open for now as your description suggests you wish to add further tests.

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.


5 years ago

#12 @hellofromTonya
5 years ago

  • Keywords has-patch has-unit-tests removed
  • Milestone 5.8 → 5.9

Punting the remaining work for this ticket to the next milestone for completion.

#13 @hellofromTonya
5 years ago

  • Resolution → fixed
  • Status assigned → closed

Closing as all work has been committed.

Note: See TracTickets for help on using tickets.