Coding standard : Undefined varible $results

[ravipatel]

Variable "$results" is undefined.

[ravipatel]

undefine variable $results

[jrf]

@ravipatel The report is valid and the patch good. Thanks for that.

Having said that, I think we may need to rethink the practice happening here.

The first few functions in this file, all end with something along the lines of:

<?php
// Unset to save memory.
unset( $results, $r );

return $hashtable;

With how PHP memory management and garbage collection works, this, to me, is ludicrous.

Variables created within the scope of a function are discarded automatically when PHP leaves the scope of the function, i.e. on return, so doing a call to unset() straight before a return statement is absolutely unnecessary and useless.

These statements can, and should be, removed.

[rachelbaker]

Introduced in [14760] from #13034.

Trac ticket: https://core.trac.wordpress.org/ticket/52996

[mukesh27]

​PR1181 removes all resets.

Please check and let me know in case of any changes. Feel free to update.

[SergeyBiryukov]

In 50692:

Coding Standards: Remove unnecessary unset() calls in WP_Importer methods.

Variables created within the scope of a function are discarded automatically when PHP leaves the scope of the function, i.e. on return, so doing a call to unset() straight before a return statement is redundant.

Props jrf, ravipatel, rachelbaker, mukesh27.
Fixes #52996.

[jrf]

Thanks @mukesh27 and @SergeyBiryukov for getting that fixed up!