Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 4 months ago

#53032 closed defect (bug) (fixed)

Privacy: "Retry" action link on "Export Personal Data" page does not work

Reported by: davidbaumwald's profile davidbaumwald Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-patch needs-testing
Focuses: javascript Cc:

Description

During work on #52892, part of the testing process involves forcing an export failure. Upon failure, each row displays "Download failed." and a "Retry" link. However, clicking this link appears to currently do nothing.

Steps to reproduce:

  1. Add this script as a must-use file.
  2. Go to "Tools" > "Export Personal Data" and add a test user in the "Username or email address" field to generate a request.
  3. Hover over the email and click on "Download personal data".
  4. Once "Download failed" appears, click the "Retry" link, and nothing happens.

Props to @hellofromTonya for helping to confirm this bug.

Attachments (3)

53032.diff (592 bytes) - added by NomNom99 3 years ago.
Fixes retry on failure button
53032.2.diff (1.4 KB) - added by NomNom99 3 years ago.
Add class to HTML
53032.3.diff (2.0 KB) - added by rafiahmedd 2 years ago.
Added class in line 142

Download all attachments as: .zip

Change History (14)

This ticket was mentioned in PR #1201 on WordPress/wordpress-develop by Sidsector9.


3 years ago
#1

  • Keywords has-patch added

Fixes export of personal data when the retry on failure button is clicked.
Trac ticket: https://core.trac.wordpress.org/ticket/53032

@NomNom99
3 years ago

Fixes retry on failure button

@NomNom99
3 years ago

Add class to HTML

#2 @davidbaumwald
3 years ago

  • Keywords needs-testing added

@NomNom99 Thanks for the patch! The second approach looks better to me. Updating the keywords here to ask for testing of your fix.

#3 @davidbaumwald
2 years ago

#55168 was marked as a duplicate.

#4 @davidbaumwald
2 years ago

  • Milestone changed from Awaiting Review to 6.0

#5 @davidbaumwald
2 years ago

#55168 was marked as a duplicate.

@rafiahmedd
2 years ago

Added class in line 142

#6 @SergeyBiryukov
2 years ago

Just to clarify my comment from #55168, I'm not quite sure if the change on line 142 is needed, it just seemed that way when looking at the code. Would be great to test and confirm whether it's needed or not.

#7 @davidbaumwald
2 years ago

  • Owner set to davidbaumwald
  • Status changed from new to reviewing

#8 @hasanuzzamanshamim
2 years ago

I tested with the latest patch, Just adding the missing class export-personal-data-handle on line 63 is solved the personal data retry button issue. And the email retry button is working as expected without the class export-personal-data-handle.
So, I think there is no need to add it on line 142.

you can check the test case here:
https://drive.google.com/file/d/1yaku_51cjfuvsrMcdFw7wwkeMv1RvMUc/view?usp=sharing

#9 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52846:

Privacy: Fix "Retry" action after a personal data export failure.

When exporting personal data for a user request, if the export fails for any reason, a "Retry" link is displayed inline. However, up to this point, clicking this link performed no action. This change adds the export-personal-data-handle CSS class to the link to make sure it's picked up by the same delegated listener as the initial action. Clicking this link will now retry the export.

Props hellofromTonya, nomnom99, rafiahmedd, SergeyBiryukov, hasanuzzamanshamim.
Fixes #53032.

dream-encode commented on PR #1201:


2 years ago
#10

Thanks for the PR! This was merged into core in https://core.trac.wordpress.org/changeset/52846.

bahalkanisahab473 commented on PR #1201:


4 months ago
#11

Ensure browser compatibility, stable internet, clear cache, and contact support for the "Retry" issue on the "Export Personal Data" page.

Note: See TracTickets for help on using tickets.