WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#53035 new defect (bug)

Copy suggested policy text to clipboard on click success message is not showing

Reported by: sumitsingh's profile sumitsingh Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots needs-testing needs-refresh
Focuses: administration, privacy Cc:

Description

Hi,

I have updated 5.7.1. and lot's of time success message is not showing. more information you can see mentioned quick video link.

​https://www.loom.com/share/6d051f6236134b6eb6aff20fba228b9e

Attachments (1)

53035.patch​ (691 bytes) - added by mukesh27 4 years ago.

Download all attachments as: .zip

Change History (5)

#1 @mukesh27
4 years ago

  • Focuses accessibility removed
  • Keywords has-patch added
  • Version 5.7.1 deleted

Hi there!

Thanks for the ticket. I reproduce the issue in a fresh installation.

Privacy button uses the <span> tag for text wrapping and when you click on the text javascript target span element instead of a button.

Same issue in development version 5.8-alpha-50717

@mukesh27
4 years ago

#2 @mukesh27
4 years ago

  • Keywords needs-testing added

53035.patch​ fixed the issue. added 'needs-testing` keyword for more testing.

Feel free to update it.

#3 @Hareesh Pillai
3 years ago

  • Keywords needs-refresh added; has-patch removed

Thanks for the patch, Mukesh.

While testing, I notice that the "Copied!" text isn't cleared once it appears on the screen.
The expected behaviour is that it should disappear after 3 seconds.

#4 @mukesh27
3 years ago

Thanks for testing, Hareesh.

Patch working fine for me and the "Copied!" text disappears after 3 seconds.

The patch was created in the main JS file so please add define( 'SCRIPT_DEBUG', true ); when you test the patch.

Note: See TracTickets for help on using tickets.