Opened 4 years ago
Closed 4 years ago
#53059 closed enhancement (fixed)
Coding Standards: Give some variables in WP_Widget_Pages a more meaningful name
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Widgets | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
In widget WP_Widget_Pages it use $out
variable. As per Coding Standards, we should use some meaningful name like $output
Change History (7)
This ticket was mentioned in PR #1196 on WordPress/wordpress-develop by mukeshpanchal27.
4 years ago
#1
- Keywords has-patch added
#5
@
4 years ago
Thanks so much for this ticket and patch, @mukesh27!
In the future when reporting coding standards issues like this, please try to review entire files at a time and detail which files you reviewed when you discovered the issue. For example, I just reviewed the other classes in wp-includes/widgets
for this same issue, and it seems the only occurrence is in WP_Widget_Pages
.
Changes like this are also really great for adding the good-first-bug
keyword to. It's important to leave some easier tickets for contributors just getting involved with WordPress so that there are tickets they can feel confident jumping into!
Also, every release has a coding standards improvement task. For 5.8, it's #52627. If there are small, one off changes like this, they can be posted on the task ticket for the current release. It helps group all of the coding standards related changes in one place for future reference.
Trac ticket: https://core.trac.wordpress.org/ticket/53059