Opened 4 years ago
Closed 4 years ago
#53112 closed defect (bug) (fixed)
Twenty Nineteen - Pullquote block editor styling breaks with block alignment set
Reported by: | devnel | Owned by: | sabernhardt |
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | 5.7.1 |
Component: | Bundled Theme | Keywords: | has-patch needs-testing |
Focuses: | css | Cc: |
Description
Steps to reproduce the behavior
- Activate Twenty Nineteen
- Add a pull-quote block to any page
- Apply "wide-align" or any other block alignment option
- See the issue
What I expected to happen
The editor styling shows by default with the theme font styles (italic etc.) just like without alignment.
What actually happened
The editor styling of the text in the block doesn't reflect the correct size and font-decoration. The styling is still displayed correctly on the front-end and without any alignment options active.
Tested with latest WordPress version installed and no plugins active.
Attachments (7)
Change History (15)
#2
@
4 years ago
- Keywords has-patch needs-testing added
@devnel Thanks for the report!
53112.patch sets all editor pullquote styles to put the quote in italics and remove all-caps from the citation with Twenty Nineteen.
I also noticed a discrepancy between pullquote block alignment options with the Twenty Twenty theme, but I'm unsure whether that would be better on a separate ticket.
#3
@
4 years ago
- Milestone changed from Awaiting Review to 5.8
Moving to 5.8 because it would be nice to fix as many editor bugs in the default themes as possible. But with the focus on full site editing, this would need someone to own.
#5
@
4 years ago
- Keywords needs-testing removed
I tested the patch locally and can confirm it fixes the issue.
#6
@
4 years ago
- Keywords needs-testing added
Using longer quotes, the left- and right-aligned pullquotes are more obviously centered in the editor.
On the front end both left and right are aligned the same direction as the language default. I added the text-align: left
to the editor version even though there is no RTL version (so those blocks would not match the front end in RTL anyway).
If it's better to leave the text centered in the block and float those pullquote blocks to the side, we could remove that text alignment and keep the max-width
for the editor.
#7
@
4 years ago
To remove the LTR bias of my previous patch, the text alignment is updated to use inherit
in 53112.2.patch. So now it should be correct for both language directions.
Correct styling with no alignment set