class-walker-comment.php has call to remove_filter with incorrect number of arguments

[diddledani]

Line 203:

remove_filter( 'comment_text', array( $this, 'filter_comment_text' ), 40, 2 );

Should be:

remove_filter( 'comment_text', array( $this, 'filter_comment_text' ), 40 );

(github PR will be attached)

Nit: remove_filter takes 3 parameters with 4 given. This might cause a PHP Warning message.

Trac ticket: https://core.trac.wordpress.org/ticket/53113

[SergeyBiryukov]

Good catch! Introduced in [47887].

[mukesh27]

Hi there!

Can you please update PR and do the below change also?

​https://github.com/WordPress/WordPress/blob/master/wp-includes/class-walker-comment.php#L185

add_filter( 'comment_text', array( $this, 'filter_comment_text' ), 40, 2 );

Replace to

add_filter( 'comment_text', array( $this, 'filter_comment_text' ), 40 );

[diddledani]

@mukesh27 that add_filter call looks correct to me. Why do you think we need to drop the priority?

[davidbaumwald]

As @diddledan mentions, I think the add_filter is correct, as it's passing 2 params to filter_comment_text. This ticket deals with removing a filter, which doesn't care about the param count.

[mukesh27]

Got it. Ready to commit

[davidbaumwald]

In 50816:

Comments: Remove fourth parameter on remove_filter call.

In class-walker-comment.php, a remove_filter call on comment_text passed a fourth parameter which was not needed. This change removes the extra argument.

Props diddledan, SergeyBiryukov.
Fixes #53113.

Thanks for the PR! This was merged in r50816.