#53142 closed defect (bug) (fixed)
Add labels for permalink settings error textareas
Reported by: | sabernhardt | Owned by: | joedolson |
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Permalinks | Keywords: | has-patch has-screenshots commit |
Focuses: | accessibility, administration | Cc: |
Description (last modified by )
When saving permalinks, if the server configuration file or the root directory is unwritable, the error message contains a read-only textarea without a label tag.
Attachments (3)
Change History (12)
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
3 years ago
@
3 years ago
adding a label to each error message's rewrite rules textarea (and adding rows to htaccess textarea)
#7
@
3 years ago
- Description modified (diff)
Testing process
- Ideally, make the web.config file, root directory or .htaccess file unwritable. If that's not possible in your installation, adjust conditions within options-permalink.php to return true to force each error (see below).
- Navigate to Settings -> Permalinks.
- Select a different permalink option and Save changes.
- Check for a label with the read-only form element.
Ways to fake each situation
web.config
is not writable
Replace the 3 consecutive conditional statements with true statements:
if ( $iis7_permalinks ) : if ( isset( $_POST['submit'] ) && $permalink_structure && ! $using_index_permalinks && ! $writable ) : if ( file_exists( $home_path . 'web.config' ) ) :
root directory is not writable to edit/create web.config
Replace only the first 2 conditions with true statements (file_exists( $home_path . 'web.config' )
needs to remain false):
if ( $iis7_permalinks ) : if ( isset( $_POST['submit'] ) && $permalink_structure && ! $using_index_permalinks && ! $writable ) :
.htaccess
is not writable
Only replace this statement with a true condition:
if ( $permalink_structure && ! $using_index_permalinks && ! $writable && $htaccess_update_required ) :
Version 0, edited 3 years ago
by
(next)
This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.
3 years ago
Note: See
TracTickets for help on using
tickets.
53142.diff uses the same "Rewrite rules:" label text for the single textarea, whether it's for the web.config or .htaccess file.
I also added two rows to the .htaccess rules textarea.