Make WordPress Core

Opened 4 years ago

Closed 5 months ago

#53146 closed defect (bug) (invalid)

Bundled Themes: More consistent styling of the search block

Reported by: deborah86's profile deborah86 Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.7.1
Component: Bundled Theme Keywords: needs-design reporter-feedback close
Focuses: css Cc:

Description (last modified by sabernhardt)

The search block is missing styling from the theme. The search widget in the footer has the styles in the stylesheet. The search block used on pages and posts does not have styles.

The unstyled attributes are:

.wp-block-search
.wp-block-search__input
.wp-block-search__button svg

Image of the search block on a page vs the search bar widget in the footer.
https://t2.dhostingsites.com/wp-content/uploads/2021/05/Screenshot-2021-05-03-5.36.53-PM-e1620088694646.png
https://t2.dhostingsites.com/search-block-doesnt-have-styles/

Attachments (12)

twentyten.png (476.3 KB) - added by desrosj 4 years ago.
twentyeleven.png (597.3 KB) - added by desrosj 4 years ago.
twentytwelve.png (81.4 KB) - added by desrosj 4 years ago.
twentythirteen.png (217.4 KB) - added by desrosj 4 years ago.
twentyfourteen.png (72.0 KB) - added by desrosj 4 years ago.
twentyfifteen.png (84.1 KB) - added by desrosj 4 years ago.
twentysixteen.png (67.9 KB) - added by desrosj 4 years ago.
twentyseventeen.png (376.7 KB) - added by desrosj 4 years ago.
twentynineteen.png (104.7 KB) - added by desrosj 4 years ago.
twentytwenty.png (118.0 KB) - added by desrosj 4 years ago.
twentytwentyone.png (99.8 KB) - added by desrosj 4 years ago.
search-wp62.png (66.8 KB) - added by poena 20 months ago.
Search blocks that are already styled in 6.2

Change History (23)

#1 @deborah86
4 years ago

  • Focuses css added
  • Version set to 5.7.1

#2 @desrosj
4 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-design added
  • Summary changed from Twenty Twenty: Search Block Missing Styling when Used in Post or Page to Bundled Themes: More consistent styling of the search block

Thanks for this one, @deborah86!

I'm changing this ticket to be a bit more broad. It seems that several default themes have inconsistent styling for the search block in the sense that the block does not match or resemble other search forms in the theme. It's worth taking a look at all of these.

The block does have styles, they are just the default ones that ship with the block editor. For some of the default themes, it doesn't actually look that bad. But for others, it does stand out as pretty different. I've marked needs-design to get some feedback on what adjustments should be made in each theme.

I'll be attaching screenshots for each theme with both a serach form and a search block visible. These screenshots are all of the front end, but any adjustments that are made should also be made to the block's presentation in the editor.

Other search block related tickets: #52433, #50609.

@desrosj
4 years ago

@desrosj
4 years ago

@desrosj
4 years ago

@desrosj
4 years ago

@desrosj
4 years ago

@desrosj
4 years ago

#3 @sabernhardt
4 years ago

  • Description modified (diff)

Is it possible to change the block markup in the editor to match the searchform.php markup for themes like Twenty Twenty? (as a block option)

#4 @deborah86
3 years ago

Has this been updated? The status is still awaiting review.

#5 @poena
20 months ago

  • Owner set to poena
  • Status changed from new to assigned

#6 @poena
20 months ago

  • Milestone changed from Awaiting Review to 6.3

#7 @poena
20 months ago

In Twenty Ten, there is a spacing issue that should be solved, other than that, the search has no special styling.

For 11, 12, 13, and 15, I am not sure what the expected result is since the search widget is not really styled and the theme can not set a default setting for the search block that hides the submit button.

For 21 I am also not sure what the expected result/change is.

Update: I found that 14, 16, 17, 19, and 20 have already been fixed, the button color now matches the search widget. I am not sure if it was a theme change or a change to the block.

Last edited 20 months ago by poena (previous) (diff)

@poena
20 months ago

Search blocks that are already styled in 6.2

#8 @poena
19 months ago

  • Milestone changed from 6.3 to Awaiting Review

#9 @poena
17 months ago

  • Keywords reporter-feedback added
  • Owner poena deleted

#10 @karmatosed
5 months ago

  • Keywords close added

Unless I am mistaken for now this could be closed as individual themes have been worked on. I am going to recommend that and we can always review. Thank you everyone.

#11 @karmatosed
5 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

For now I am going to go ahead and close this, thank you everyone.

Note: See TracTickets for help on using tickets.