WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53151 closed defect (bug) (fixed)

Replace esc_attr with esc_url in Plugin Install screen

Reported by: chintan1896's profile chintan1896 Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

Wrong Escaping Function Was Used in wp-admin/includes/class-wp-plugin-install-list-table.php

Attachments (2)

53151.diff​ (724 bytes) - added by chintan1896 5 years ago.
Capture d’écran 2021-05-04 à 13.36.34.png​ (257.9 KB) - added by audrasjb 5 years ago.

Download all attachments as: .zip

Change History (6)

@chintan1896
5 years ago

@audrasjb
5 years ago

#1 @audrasjb
5 years ago

  • Milestone changed from Awaiting Review to 5.8
  • Summary changed from Replace esc_attr with esc_url in class-wp-plugin-install-list-table.php to Replace esc_attr with esc_url in Plugin Install screen

Related: #53150

Looks good to go, thanks. Moving to 5.8 with commit workflow keyword.

@chintan1896 maybe it would be better to handle all of those items at once in a dedicated ticket?

#2 @audrasjb
5 years ago

  • Keywords commit added

#3 @desrosj
5 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#4 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50808:

General: Use correct escaping function for the plugin icon URL.

Props chintan1896, audrasjb.
Fixes #53151.

Note: See TracTickets for help on using tickets.