#53157 closed enhancement (fixed)
Replace table tags for color palettes on user profile screen
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.5 | Priority: | normal |
| Severity: | minor | Version: | |
| Component: | Users | Keywords: | has-patch needs-dev-note |
| Focuses: | accessibility, css, administration | Cc: |
Description
To avoid the semantics of tables, the color palettes' table tags can be replaced with generic div tags.
Attachments (1)
Change History (13)
#2
@
2 years ago
- Focuses accessibility added
- Milestone changed from Future Release to 6.5
- Owner set to joedolson
- Status changed from new to accepted
At minimum, these should have role="presentation", but I can't see any good reason not to replace these. This is also an accessibility issue, since it's a misrepresentation of the information in tabular format, though that's relatively minor.
This ticket was mentioned in PR #5657 on WordPress/wordpress-develop by @sabernhardt.
2 years ago
#4
- Keywords needs-refresh removed
- Replaces table elements.
- Adds a
.color-palette-shadeclass to the innerdivelements. - Updates styles to fit the new elements.
#5
@
2 years ago
Of the plugins that target the `.color-palette` class, a few include table or td elements. However, among the plugins I was able to check, the change seems to have few/minor effects.
- WP Dark Mode would need to update the script that targets the table for its color adjustments.
- Hide My WP Ghost has a copy of core styles and scripts for the login page. If the plugin also enqueues those copies within the admin, the files would require updating.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
2 years ago
@joedolson commented on PR #5657:
2 years ago
#10
Fixed in r57572
This seems like it would be fine. I can't think of any backwards compatibility issues here unless someone is targeting the color palette tables to style them differently. But I think that's a long shot.
Moving to Future Release for now and can revisit after FSE in 5.8.