Make WordPress Core

Opened 3 years ago

Closed 4 months ago

Last modified 3 months ago

#53157 closed enhancement (fixed)

Replace table tags for color palettes on user profile screen

Reported by: sabernhardt's profile sabernhardt Owned by: joedolson's profile joedolson
Milestone: 6.5 Priority: normal
Severity: minor Version:
Component: Users Keywords: has-patch needs-dev-note
Focuses: accessibility, css, administration Cc:


To avoid the semantics of tables, the color palettes' table tags can be replaced with generic div tags.

Attachments (1)

53157.diff (1.8 KB) - added by sabernhardt 3 years ago.

Download all attachments as: .zip

Change History (13)

3 years ago

#1 @desrosj
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

This seems like it would be fine. I can't think of any backwards compatibility issues here unless someone is targeting the color palette tables to style them differently. But I think that's a long shot.

Moving to Future Release for now and can revisit after FSE in 5.8.

#2 @joedolson
7 months ago

  • Focuses accessibility added
  • Milestone changed from Future Release to 6.5
  • Owner set to joedolson
  • Status changed from new to accepted

At minimum, these should have role="presentation", but I can't see any good reason not to replace these. This is also an accessibility issue, since it's a misrepresentation of the information in tabular format, though that's relatively minor.

#3 @sabernhardt
7 months ago

  • Keywords needs-refresh added

This ticket was mentioned in PR #5657 on WordPress/wordpress-develop by @sabernhardt.

7 months ago

  • Keywords needs-refresh removed
  • Replaces table elements.
  • Adds a .color-palette-shade class to the inner div elements.
  • Updates styles to fit the new elements.

Trac 53157

#5 @sabernhardt
7 months ago

Of the plugins that target the `.color-palette` class, a few include table or td elements. However, among the plugins I was able to check, the change seems to have few/minor effects.

  1. WP Dark Mode would need to update the script that targets the table for its color adjustments.
  2. Hide My WP Ghost has a copy of core styles and scripts for the login page. If the plugin also enqueues those copies within the admin, the files would require updating.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.

4 months ago

#7 @joedolson
4 months ago

  • Keywords commit added

#8 @joedolson
4 months ago

  • Severity changed from normal to minor

Let's be honest, this is pretty minor.

#9 @joedolson
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57572:

Users: Replace table tags for color palettes in profiles.

Replace the table element used to present color palette selection in the user profile screen with generic elements. The extra semantics of a table are at best unhelpful and have some potential to great extraneous verbosity for screen readers.

Props sabernhardt, desrosj.
Fixes #53157.

@joedolson commented on PR #5657:

4 months ago

Fixed in r57572

#11 @stevenlinx
3 months ago

  • Keywords needs-dev-note added

as a misc note

#12 @sabernhardt
3 months ago

  • Keywords commit removed

I wrote a rough first draft for the dev note.

Note: See TracTickets for help on using tickets.