WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#53180 closed defect (bug) (fixed)

Regression: should_load_separate_core_block_assets() function not found without SCRIPT_DEBUG

Reported by: aristath's profile aristath Owned by: gziolo's profile gziolo
Milestone: 5.8 Priority: high
Severity: normal Version: 5.8
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

Caused by https://core.trac.wordpress.org/changeset/50836
load-styles.php doesn't load the should_load_separate_core_block_assets function and that causes an error 500 - which in turn makes the dashboard appear unstyled.
Originally this was missed because this doesn't happen when SCRIPT_DEBUG is enabled.

Change History (6)

This ticket was mentioned in ​PR #1247 on ​WordPress/wordpress-develop by ​aristath.
5 years ago #1

  • Keywords has-patch added

Fixes regression - error 500 in load-styles.php when SCRIPT_DEBUG is not enabled.

Trac ticket: https://core.trac.wordpress.org/ticket/53180

#2 @gziolo
5 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.8
  • Owner changed from aristath to gziolo

#4 @SergeyBiryukov
5 years ago

  • Component changed from General to Editor
  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from Regression: Error to Regression: Error to Regression: should_load_separate_core_block_assets() function not found without SCRIPT_DEBUG

Fixed in [50837].

#5 @SergeyBiryukov
5 years ago

In 50838:

Editor: Some documentation and test improvements for loading separate assets for core blocks:

  • Move should_load_separate_core_block_assets() to a more appropriate place.
  • Update DocBlocks and inline comments per the documentation standards.
  • Document the $wp_styles global in wp_maybe_inline_styles().
  • List the expected result first in unit test assertions.
  • Remove a duplicate unit test.
  • Add missing @covers tags.

Follow-up to [50836], [50837].

See #50328, #52620, #53180.

#6 @SergeyBiryukov
5 years ago

  • Summary changed from Regression: Error to Regression: should_load_separate_core_block_assets() function not found without SCRIPT_DEBUG to Regression: should_load_separate_core_block_assets() function not found without SCRIPT_DEBUG
Note: See TracTickets for help on using tickets.