WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 12 months ago

#53182 closed defect (bug) (fixed)

define()s for Network don't conform to WordPress coding standards

Reported by: paulschreiber Owned by: SergeyBiryukov
Priority: normal Milestone: 5.8
Component: Networks and Sites Version:
Severity: normal Keywords: has-patch
Cc: Focuses: multisite, coding-standards

Description

When you generate a multisite network, WordPress creates some define() statements for you to paste in to wp-config.php.

Those statements lack spacing and don't conform to WordPress coding standards.

Change History (7)

This ticket was mentioned in ​PR #1248 on ​WordPress/wordpress-develop by ​paulschreiber.
5 years ago #1

  • Keywords has-patch added

Adds spacing so define() statements conform to WordPress coding standards.

Trac ticket: https://core.trac.wordpress.org/ticket/53182

#2 @johnjamesjacoby
5 years ago

👍 PR looks good to me.

#3 @SergeyBiryukov
5 years ago

  • Milestone Awaiting Review → 5.8

#4 @SergeyBiryukov
5 years ago

  • Focuses coding-standards added

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 50839:

Coding Standards: Adds spacing so define() statements displayed when creating a network.

This ensures that the code intended to be copied to wp-config.php conforms to WordPress Coding Standards.

Props paulschreiber, johnjamesjacoby.
Fixes #53182.

​@SergeyBiryukov commented on ​PR #1248:
12 months ago #6

Thanks for the PR! Merged in r50839.

​@paulschreiber commented on ​PR #1248:
12 months ago #7

What happened here? This PR was over four years old.

Note: See TracTickets for help on using tickets.