WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#53196 closed defect (bug) (fixed)

Twenty Twenty: Remove Git related information in package.json file

Reported by: desrosj Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

The Twenty Twenty theme has some outdated information in the package.json file pointing to the archived Git repository.

For parity with the other default themes, repository can be removed. The bugs and homepage should also be changed to point to the theme's WordPress.org theme directory URL and Trac.

Change History (6)

#1 @mukesh27
5 months ago

Hi there!

If you are new and want to contribute to this ticket please follow below code change.

Remove this line of code - https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwenty/package.json#L13-L16

Replace bugs URL at https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwenty/package.json#L18

https://core.trac.wordpress.org/

Replace homepage link at https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwenty/package.json#L12

https://wordpress.org/themes/twentytwenty/

This ticket was mentioned in PR #1261 on WordPress/wordpress-develop by arjkb.


4 months ago

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53196

The TwentyTwenty theme had outdated information in its package.json file. This PR:

  1. Removes repository section of package.json
  2. Updates bugs URL
  3. Updates homepage link

#3 @arkrs
4 months ago

I've made a pull request on GitHub fixing this issue.

#4 @mukesh27
4 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 5.8

@arkrs thanks for the patch. PR looks fine to me.

Mark as commit and set milestone to 5.8

#5 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 50924:

Twenty Twenty: Update theme information in the package.json file.

This removes references to the archived Git repository and updates the URLs to point to the theme's WordPress.org Theme Directory URL and Trac.

Props arkrs, desrosj, mukesh27.
Fixes #53196.

#6 @SergeyBiryukov
4 months ago

In 50925:

Twenty Nineteen: Update theme information in the package.json file.

This removes references to the archived Git repository and updates the URLs to point to the theme's WordPress.org Theme Directory URL and Trac.

Follow-up to [50924].

See #53196.

Note: See TracTickets for help on using tickets.