WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 9 years ago

#532 closed defect (bug) (fixed)

make_clickable() incorrectly closes quotes for created mailto: links

Reported by: coffee2code's profile coffee2code Owned by: kitten's profile Kitten
Milestone: Priority: normal
Severity: trivial Version:
Component: General Keywords:
Focuses: Cc:

Description

In wp-includes/functions-formatting.php, the function make_clickable(), when auto-hyperlinking a plaintext e-mail address, opens the A HREF with a single-quote, but closes it with a double-quote.

Attachments (1)

functions-formatting.diff​ (1.0 KB) - added by coffee2code 19 years ago.

Download all attachments as: .zip

Change History (10)

#1 @coffee2code
20 years ago

  • Patch set to No

#2 @2fargon
20 years ago

  • Patch changed from No to Yes
  • Status changed from new to assigned

#3 @Kitten
20 years ago

Deleted the orignial patch, replaced with a newer one against v1.52, also makes link be enclosed by double quotes.

#4 @Kitten
20 years ago

  • Owner changed from anonymous to Kitten

#5 @Kitten
20 years ago

  • fixed_in_version set to Current CVS
  • Resolution changed from 10 to 20
  • Status changed from assigned to closed

Patch fixes problem.

#6 @coffee2code
20 years ago

  • Resolution changed from 20 to 30
  • Status changed from closed to assigned

This patch hasn't actually been applied to the code in CVS yet. It seems premature to mark the bug as resolved before the change has been formally committed.

#7 @coffee2code
20 years ago

Change has been committed. Bug is resolved.

#8 @ryan
20 years ago

  • fixed_in_version set to 1.5
  • Resolution changed from 30 to 20
  • Status changed from assigned to closed

@coffee2code
19 years ago

This ticket was mentioned in ​Slack in #core by ojrask. ​View the logs.
9 years ago

Note: See TracTickets for help on using tickets.