Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#53234 closed defect (bug) (fixed)

Application password access text is misleading for Super Admins

Reported by: johnbillion's profile johnbillion Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.6
Component: Application Passwords Keywords: good-first-bug has-patch
Focuses: multisite Cc:

Description

The helper text for application passwords on a Multisite installation states:

Application passwords grant access to all {n} blogs in this installation that you have permissions on.

This is misleading for a Super Admin because an application password for a Super Admin grants access to all sites on the network, not just ones that they are a member of.

This text should be different for Super Admins. Something along the lines of:

Application passwords grant access to all sites on the network as you have Super Admin rights.

Attachments (2)

53234.patch (2.9 KB) - added by rsiddharth 3 years ago.
patch-v0.1 - change application password access text for super admins
53234.2022032000.patch (3.1 KB) - added by rsiddharth 2 years ago.

Download all attachments as: .zip

Change History (13)

#1 @johnbillion
3 years ago

  • Focuses multisite added
  • Keywords good-first-bug added

@rsiddharth
3 years ago

patch-v0.1 - change application password access text for super admins

#2 @rsiddharth
3 years ago

  • Keywords has-patch added; needs-patch removed

@johnbillion, uploaded a initial version of the patch. See if it looks good.

Version 0, edited 3 years ago by rsiddharth (next)

This ticket was mentioned in Slack in #core by rsiddharth. View the logs.


2 years ago

#4 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.0

#5 follow-up: @audrasjb
2 years ago

  • Keywords needs-patch added; has-patch removed

Thanks for the patch @rsiddharth but the strings you added need to be ready for internationalization. There are not translatable for now in 53234.patch.

#6 in reply to: ↑ 5 @rsiddharth
2 years ago

  • Keywords has-patch added; needs-patch removed

Replying to audrasjb:

Thanks for the patch @rsiddharth but the strings you added need to be ready for internationalization. There are not translatable for now in 53234.patch.

@audrasjb, Thank you for reviewing the patch. I've uploaded a new patch. See if it looks good.

#7 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for updating the patch!
Self assigning for review.

#9 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53101:

Application Passwords: Use a more appropriate helper text message for super-admins.

Previously, the helper text of the application password section was misleading for a Super Admin because an application password for a Super Admin grants access to all sites on the network, not just ones that they are a member of. This changeset provides a slightly different message for Super admin role.

Props johnbillion, rsiddharth, audrasjb.
Fixes #53234

#11 @SergeyBiryukov
2 years ago

In 53102:

I18N: Add missing translator comment for application password helper text for Super Admins.

Follow-up to [53101].

See #53234.

Note: See TracTickets for help on using tickets.