Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53250 closed enhancement (fixed)

Remove query context leftovers

Reported by: ntsekouras's profile ntsekouras Owned by: youknowriad's profile youknowriad
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Initially there were some exploration on different handling of Query and QueryLoop blocks that would aim to inherit the global query from the URL. These leftovers should be removed.

Change History (5)

This ticket was mentioned in PR #1276 on WordPress/wordpress-develop by ntsekouras.


3 years ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53250

Initially there were some exploration on different handling of Query and QueryLoop blocks that would aim to inherit the global query from the URL. This PR removes these leftovers.

youknowriad commented on PR #1276:


3 years ago
#2

This makes sense to me, the query block has never been part of Core.

#3 @youknowriad
3 years ago

  • Milestone changed from Awaiting Review to 5.8

#4 @youknowriad
3 years ago

  • Owner set to youknowriad
  • Resolution set to fixed
  • Status changed from new to closed

In 50950:

Block Editor: Removed useless block editor render context value.

The "query" context value was meant to be used by the Query block.
But the block has been refactored to avoid relying on context for this.

Props ntsekouras.
Fixes #53250.

youknowriad commented on PR #1276:


3 years ago
#5

This is now committed.

Note: See TracTickets for help on using tickets.