WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 6 weeks ago

#53303 new enhancement

Widget type REST API endpoint should be sorted by id

Reported by: spacedmonkey Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: REST API Keywords: has-patch has-unit-tests early
Focuses: rest-api Cc:

Description

The results of Widget type REST API endpoint should be sorted by widget type id to make the output more readable.

Change History (11)

This ticket was mentioned in PR #1321 on WordPress/wordpress-develop by spacedmonkey.


8 weeks ago

  • Keywords has-patch added; needs-patch removed

#2 @spacedmonkey
8 weeks ago

@TimothyBlynJacobs Any chance of a review?

#3 @prbot
8 weeks ago

TimothyBJacobs commented on PR #1321:

lgtm, can you add a test?

#4 @prbot
8 weeks ago

spacedmonkey commented on PR #1321:

lgtm, can you add a test?

You know I looked into a test, but couldn't think of a good one. Any thoughts?

#5 @hellofromTonya
7 weeks ago

  • Keywords needs-unit-tests added
  • Milestone changed from 5.8 to 5.9

Today is 5.8 Beta 1. As work continues, punting to 5.9.

#6 @prbot
7 weeks ago

spacedmonkey commented on PR #1321:

@TimothyBJacobs What tests should I add?

#7 @spacedmonkey
7 weeks ago

@hellofromTonya I personally think this not being sorted correctly is a bug. It is a one liner that doesn't really need test IMO.

#8 @prbot
7 weeks ago

TimothyBJacobs commented on PR #1321:

Sorry for not getting back to you earlier. I'd probably just ksort the result in the tests and assert that it is the same as the returned, non-sorted version.

#9 @prbot
6 weeks ago

spacedmonkey commented on PR #1321:

@TimothyBJacobs I have added a unit test.

#10 @spacedmonkey
6 weeks ago

  • Keywords has-unit-tests added; needs-unit-tests removed

#11 @spacedmonkey
6 weeks ago

  • Keywords early added
Note: See TracTickets for help on using tickets.