Make WordPress Core

Opened 5 years ago

Closed 2 years ago

Last modified 17 months ago

#53314 closed defect (bug) (fixed)

Add Themes page in UI issue

Reported by: sumitsingh Owned by: audrasjb
Priority: normal Milestone: 6.7
Component: Themes Version: 5.7.2
Severity: normal Keywords: has-patch has-test-info has-dev-note
Cc: Focuses: ui, css, administration

Description

Hi ,

i have found some small issue on IPhone on add new theme page on admin side.

More information you can see mentioned screenshot.

Thank you

Attachments (4)

Add Themes ‹ C (1).png​ (45.4 KB ) - added by sumitsingh 5 years ago.
Your WordPress.org username: on button alignment issue
Add Themes ‹ C (2).png​ (47.6 KB ) - added by sumitsingh 5 years ago.
Edit Filters screen
Mobile - add themes - Screenshot-1.jpg​ (81.6 KB ) - added by krupajnanda 2 years ago.
Mobile - add themes -Screenshot - 2.jpg​ (96.8 KB ) - added by krupajnanda 2 years ago.

Download all attachments as: .zip

Change History (29)

@sumitsingh
5 years ago

Your WordPress.org username: on button alignment issue

@sumitsingh
5 years ago

Edit Filters screen

#1 follow-up: @gauravtiwari
5 years ago

iPhone uses ubuntu font?

#2 in reply to: ↑ 1 ; follow-up: @sumitsingh
5 years ago

Hi,

What the reply 😂🤣

Any device in check responsive on any Operating system by Developer. I think you are not a developer otherwise you can understand with screenshot.

Replying to gauravtiwari:

iPhone uses ubuntu font?

#3 in reply to: ↑ 2 @gauravtiwari
5 years ago

  • Resolution → invalid
  • Severity normal → trivial
  • Status new → closed

No need to get offended. The thing is that virtual devices and dev tools' device screenshots work differently than original devices.

My iPhone uses SFUi font and I cannot see this problem yet.

Can you please confirm which iOS version you are using? Maybe your safari is outdated.

Replying to sumitsingh:

Hi,

What the reply 😂🤣

Any device in check responsive on any Operating system by Developer. I think you are not a developer otherwise you can understand with screenshot.

Replying to gauravtiwari:

iPhone uses ubuntu font?

Version 0, edited 5 years ago by gauravtiwari (next)

This ticket was mentioned in ​Slack in #core by gauravtiwari. ​View the logs.


5 years ago

#5 @gauravtiwari
5 years ago

  • Resolution invalid
  • Severity trivial → normal
  • Status closed → reopened

#6 @sabernhardt
5 years ago

  • Keywords needs-patch added

The filter tags list could be fixed by adding display: inline-block, and I would prefer removing the 11px font size.

I also think the username label, input and button would be better stacked vertically—with a margin between them—at the 782px breakpoint.

#7 @sumitsingh
5 years ago

Any update abouth this ticket Guys?

This ticket was mentioned in ​PR #6874 on ​WordPress/wordpress-develop by ​@Benjamin_Zekavica.


2 years ago
#8

  • Keywords has-patch added; needs-patch removed

#9 @Benjamin_Zekavica
2 years ago

  • Keywords needs-testing added

@sumitsingh I fixed it by using flexbox. See here: ​https://github.com/WordPress/wordpress-develop/pull/6874

#10 @audrasjb
2 years ago

  • Milestone Awaiting Review → 6.7
  • Owner set to audrasjb
  • Status reopened → accepted

#11 @krupajnanda
2 years ago

  • Keywords has-screenshots has-testing-info added; needs-testing removed

Hi,

Test Report

Description

This report validates whether the indicated PR works as expected.

PR tested: ​https://github.com/WordPress/wordpress-develop/pull/6874

Environment

  • WordPress: 6.6-beta3-58440-src
  • PHP: 8.2.15
  • Server: nginx/1.25.3
  • Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
  • Browser: Chrome 126.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.1
  • MU Plugins:
    • Safe Autoloaded Options Limit Test (MU Plugin) 1.0
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with added fix in the given PR.

I tested this with multiple devices and looks like Pr works as intended.

Supplemental Artifacts

Add as Attachment

#12 @Benjamin_Zekavica
2 years ago

@krupajnanda Thank you so much for testing :) You're awesome, good job.
@audrasjb I think it's ready to merge to the Core SVN, or you have some feedback?

​@Benjamin_Zekavica commented on ​PR #6874:


2 years ago
#13

@sabernhardt Thank you :) I will update it later and submit a new patch

#14 @Benjamin_Zekavica
2 years ago

@sabernhardt I approved your code suggestions, I hope now it's fine ?

#15 @krupajnanda
2 years ago

@krupajnanda Thank you so much for testing :) You're awesome, good job.

Thank you! 🙇‍♀️

@Benjamin_Zekavica Please let me if this is required an another round for testing.

#16 @Benjamin_Zekavica
2 years ago

@krupajnanda It would be good to test it again with the new version of the patch. Thank you :)

​@Benjamin_Zekavica commented on ​PR #6874:


2 years ago
#17

@sabernhardt I approved your changes :) I hope now it looks better?

This ticket was mentioned in ​Slack in #core by benjamin_zekavica. ​View the logs.


2 years ago

#20 @Benjamin_Zekavica
2 years ago

  • Keywords dev-feedback added

@audrasjb Please, do you can review it?

​@Benjamin_Zekavica commented on ​PR #6874:


2 years ago
#21

@sabernhardt Thank you so much for your review :)

#22 @Benjamin_Zekavica
2 years ago

  • Keywords has-patch has-screenshots has-testing-info dev-feedback removed

Code Changes are approved and it was final tested:
​https://github.com/WordPress/wordpress-develop/pull/6874#pullrequestreview-2305199599

For detailed Screenshots, please see the PR.
It's ready for merging.

Thank you @sabernhardt and @krupajnanda for Testing and Code Review and @sumitsingh for reporting this bug.

@audrasjb @williampatton @SergeyBiryukov Can anyone merge it please?

#23 @Benjamin_Zekavica
2 years ago

  • Keywords has-patch has-testing-info has-dev-note added

#24 @SergeyBiryukov
2 years ago

  • Resolution → fixed
  • Status accepted → closed

In 59022:

Themes: Improve the alignment of feature filters and inputs on Add Themes screen.

Follow-up to [35527], [38640], [40797].

Props Benjamin_Zekavica, sabernhardt, sumitsingh, gauravtiwari, krupajnanda, audrasjb, SergeyBiryukov.
Fixes #53314.

​@SergeyBiryukov commented on ​PR #6874:


2 years ago
#25

Thanks for the PR! Merged in r59022.

#26 @wordpressdotorg
17 months ago

  • Keywords has-test-info added; has-testing-info removed
Note: See TracTickets for help on using tickets.