#53314 closed defect (bug) (fixed)
Add Themes page in UI issue
| Reported by: | sumitsingh | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.7 |
| Component: | Themes | Version: | 5.7.2 |
| Severity: | normal | Keywords: | has-patch has-test-info has-dev-note |
| Cc: | Focuses: | ui, css, administration |
Description
Hi ,
i have found some small issue on IPhone on add new theme page on admin side.
More information you can see mentioned screenshot.
Thank you
Attachments (4)
Change History (29)
#2
in reply to: ↑ 1
;
follow-up:
↓ 3
@
5 years ago
Hi,
What the reply 😂🤣
Any device in check responsive on any Operating system by Developer. I think you are not a developer otherwise you can understand with screenshot.
Replying to gauravtiwari:
iPhone uses
ubuntufont?
#3
in reply to: ↑ 2
@
5 years ago
- Resolution → invalid
- Severity normal → trivial
- Status new → closed
No need to get offended. The thing is that virtual devices and dev tools' device screenshots work differently than original devices.
My iPhone uses SFUi font and I cannot see this problem yet.
Can you please confirm which iOS version you are using? Maybe your safari is outdated.
Replying to sumitsingh:
Hi,
What the reply 😂🤣
Any device in check responsive on any Operating system by Developer. I think you are not a developer otherwise you can understand with screenshot.
Replying to gauravtiwari:
iPhone uses
ubuntufont?
This ticket was mentioned in Slack in #core by gauravtiwari. View the logs.
5 years ago
#6
@
5 years ago
- Keywords needs-patch added
The filter tags list could be fixed by adding display: inline-block, and I would prefer removing the 11px font size.
I also think the username label, input and button would be better stacked vertically—with a margin between them—at the 782px breakpoint.
This ticket was mentioned in PR #6874 on WordPress/wordpress-develop by @Benjamin_Zekavica.
2 years ago
#8
- Keywords has-patch added; needs-patch removed
Trac ticket: (https://core.trac.wordpress.org/ticket/53314)](https://core.trac.wordpress.org/ticket/53314)
#### After Fix:
#9
@
2 years ago
- Keywords needs-testing added
@sumitsingh I fixed it by using flexbox. See here: https://github.com/WordPress/wordpress-develop/pull/6874
#11
@
2 years ago
- Keywords has-screenshots has-testing-info added; needs-testing removed
Hi,
Test Report
Description
This report validates whether the indicated PR works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6874
Environment
- WordPress: 6.6-beta3-58440-src
- PHP: 8.2.15
- Server: nginx/1.25.3
- Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
- Browser: Chrome 126.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.1
- MU Plugins:
- Safe Autoloaded Options Limit Test (MU Plugin) 1.0
- Plugins:
- Test Reports 1.1.0
Actual Results
- ✅ Issue resolved with added fix in the given PR.
I tested this with multiple devices and looks like Pr works as intended.
Supplemental Artifacts
Add as Attachment
#12
@
2 years ago
@krupajnanda Thank you so much for testing :) You're awesome, good job.
@audrasjb I think it's ready to merge to the Core SVN, or you have some feedback?
@Benjamin_Zekavica commented on PR #6874:
2 years ago
#13
@sabernhardt Thank you :) I will update it later and submit a new patch
#15
@
2 years ago
@krupajnanda Thank you so much for testing :) You're awesome, good job.
Thank you! 🙇♀️
@Benjamin_Zekavica Please let me if this is required an another round for testing.
#16
@
2 years ago
@krupajnanda It would be good to test it again with the new version of the patch. Thank you :)
@Benjamin_Zekavica commented on PR #6874:
2 years ago
#17
@sabernhardt I approved your changes :) I hope now it looks better?
This ticket was mentioned in Slack in #core by benjamin_zekavica. View the logs.
2 years ago
@Benjamin_Zekavica commented on PR #6874:
2 years ago
#21
@sabernhardt Thank you so much for your review :)
#22
@
2 years ago
- Keywords has-patch has-screenshots has-testing-info dev-feedback removed
Code Changes are approved and it was final tested:
https://github.com/WordPress/wordpress-develop/pull/6874#pullrequestreview-2305199599
For detailed Screenshots, please see the PR.
It's ready for merging.
Thank you @sabernhardt and @krupajnanda for Testing and Code Review and @sumitsingh for reporting this bug.
@audrasjb @williampatton @SergeyBiryukov Can anyone merge it please?
@SergeyBiryukov commented on PR #6874:
2 years ago
#25
Thanks for the PR! Merged in r59022.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Your WordPress.org username: on button alignment issue