Make WordPress Core

Opened 3 years ago

Last modified 22 months ago

#53355 reviewing defect (bug)

wp-signup.php with `new` in the query string results in a "site does not exist" message even if the site does exist

Reported by: henrywright's profile henry.wright Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch needs-testing has-unit-tests
Focuses: multisite Cc:

Description

Steps to reproduce:

  1. Visit example.com/wp-signup.php?new=sport where sport is the address of an existing site in your network. Note I'm using sport as an example. You should replace sport with the address of an existing blog in your network.

You will get the following message appear on the page:

The site you were looking for, https://sport.example.com/, does not exist, but you can create it now!

Attachments (4)

53355.diff (1.6 KB) - added by henry.wright 3 years ago.
53355.2.diff (1.8 KB) - added by henry.wright 3 years ago.
53355.3.diff (1.8 KB) - added by henry.wright 3 years ago.
53355.4.diff (1.9 KB) - added by henry.wright 3 years ago.

Download all attachments as: .zip

Change History (19)

#1 @henry.wright
3 years ago

To add, the network install I used to test allows both user and blog registrations

@henry.wright
3 years ago

#2 @henry.wright
3 years ago

  • Keywords has-patch added

53355.diff uses domain_exists() to check if a site name is already taken before outputting the message.

@henry.wright
3 years ago

#3 @henry.wright
3 years ago

53355.2.diff fixes the value of $domain which is passed to domain_exists() as the first param.

@henry.wright
3 years ago

#4 @henry.wright
3 years ago

53355.3.diff ensures the right parts of the extracted host name are used to build the domain value.

#5 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Related: #53348

@henry.wright
3 years ago

#6 @henry.wright
3 years ago

53355.4.diff adds a separation character when building the domain value

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

#9 @audrasjb
3 years ago

  • Keywords needs-testing needs-refresh added
  • Milestone changed from 5.9 to 6.0

As per today's bug scrub and since this ticket needs to be refreshed against trunk and properly tested, let's move it to next milestone.

This ticket was mentioned in Slack in #core by mike. View the logs.


2 years ago

#11 @kirasong
2 years ago

  • Keywords needs-unit-tests added; needs-refresh removed

Checked into this ticket in a bug scrub today, and here's a synopsis of the suggestions to move things forward:

Looks like the patch applies at the moment, so removing needs-refresh.

Tests would be helpful, so adding needs-unit-tests as well.

Last edited 2 years ago by kirasong (previous) (diff)

This ticket was mentioned in PR #2655 on WordPress/wordpress-develop by felipeelia.


2 years ago
#12

  • Keywords has-unit-tests added; needs-unit-tests removed

This PR aims to fix the problem outlined in ticket 53355 but also validates the field right away, so if a name of an existing blog is sent via the query string, the user will see an error in the first page load.

Trac ticket: https://core.trac.wordpress.org/ticket/53355

#13 @costdev
2 years ago

  • Milestone changed from 6.0 to 6.1

With 6.0 RC1 tomorrow and the patch still needing testing, I'm moving this ticket to the 6.1 milestone.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


22 months ago

#15 @audrasjb
22 months ago

  • Milestone changed from 6.1 to Future Release

Unfortunately, this ticket didn’t get more momentum in 6.1 than in 6.0… sorry about that, but the proposed patch still needs testing, so let's move it to Future Release milestone, at least until it's properly reviewed by a Network component maintainer.

Note: See TracTickets for help on using tickets.