WebPI parameters.xml whitespace

[fusecp]

The wordpress wp-config.php file was updates to include spaces in the define strings but the WebPI was not updated to match these strings so newer versions of the WebPI are no longer working.

I have attached a fixed version of the parameters.xml which should be included in the IIS builds.

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Just to clarify for anyone looking at this, the file appears to be located at branches/iis/parameters.xml​.

[SergeyBiryukov]

Setting the version to 5.1, as the change was made in [42343/trunk/wp-config-sample.php] / #41057.

[sabernhardt]

A .diff (patch) file would help.

To be thorough, I think the match pattern could accommodate either with or without spaces (but include the spaces in defaultValue?).

[fusecp]

Patch file for changes

[fusecp]

The current match pattern without spaces did not work as we have tested this with WebPI. The values never get replaced.

In the past there was a third party git repo used by WebPI apps but i think it would be best if we fix this in your files and allow customers to download from yourself.

If this can be added to 5.9 that would be great.

[sabernhardt]

matching zero or more spaces

[sabernhardt]

Thanks for the quick patch!

I meant using the \s* wildcard for zero or more spaces. It had been after a few commas, and this adds it before and after the quotes.

Note that I edited the patch file directly, so there easily could be an error with it.

If this can be tested and verified today, it could go back to 5.9.

[fusecp]

Tested 53377.2.patch and its working fine with WebPI

[costdev]

This ticket was discussed in the bug scrub. I've asked for input from #hosting-community Slack channel members and it would be good to get input from those rolling their own local IIS server on Windows.

[SergeyBiryukov]

It looks like 53377.2.patch​ updates defaultValue for some parameters, but not for others.

53377.3.patch​ is a refresh that consistently updates all the parameters.

I think this is safe to commit, as the current file doesn't seem to work anyway after [42343] / #41057.

It was not quite clear to me whether there are any further steps involved for newer WebPI versions to work again, besides updating this file. After some investigation, it looks like the file is included in IIS builds, as seen in the last column in the tables on the ​Releases page.

Looking at the previous update in [26870] / #26696, as well as the complete file history, there are no other steps mentioned, so let's go with this for now, comment:7 appears to confirm that updating the file should be enough.

[SergeyBiryukov]

In 53320:

General: Account for WordPress coding standards in the Microsoft IIS configuration.

This makes sure that the rules for database credentials and authentication keys account for the spaces added as part of the formatting changes to match the WordPress coding standards in [42343/trunk/wp-config-sample.php] / #41057.

Follow-up to [42218], [42343].

Props fusecp, sabernhardt, costdev, SergeyBiryukov.
Fixes #53377.