WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 3 weeks ago

#53377 new defect (bug)

WebPI parameters.xml whitespace

Reported by: fusecp Owned by:
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

The wordpress wp-config.php file was updates to include spaces in the define strings but the WebPI was not updated to match these strings so newer versions of the WebPI are no longer working.

I have attached a fixed version of the parameters.xml which should be included in the IIS builds.

Attachments (3)

parameters.xml (11.7 KB) - added by fusecp 6 months ago.
53377.patch (3.2 KB) - added by fusecp 3 weeks ago.
Patch file for changes
53377.2.patch (3.2 KB) - added by sabernhardt 3 weeks ago.
matching zero or more spaces

Download all attachments as: .zip

Change History (11)

@fusecp
6 months ago

#1 @SergeyBiryukov
6 months ago

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Just to clarify for anyone looking at this, the file appears to be located at branches/iis/parameters.xml.

#2 @SergeyBiryukov
6 months ago

  • Version changed from 5.7.2 to 5.1

Setting the version to 5.1, as the change was made in [42343/trunk/wp-config-sample.php] / #41057.

#3 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.9

#4 @sabernhardt
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from 5.9 to 6.0

A .diff (patch) file would help.

To be thorough, I think the match pattern could accommodate either with or without spaces (but include the spaces in defaultValue?).

Last edited 3 weeks ago by sabernhardt (previous) (diff)

@fusecp
3 weeks ago

Patch file for changes

#5 @fusecp
3 weeks ago

The current match pattern without spaces did not work as we have tested this with WebPI. The values never get replaced.

In the past there was a third party git repo used by WebPI apps but i think it would be best if we fix this in your files and allow customers to download from yourself.

If this can be added to 5.9 that would be great.

@sabernhardt
3 weeks ago

matching zero or more spaces

#6 @sabernhardt
3 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

Thanks for the quick patch!

I meant using the \s* wildcard for zero or more spaces. It had been after a few commas, and this adds it before and after the quotes.

Note that I edited the patch file directly, so there easily could be an error with it.

If this can be tested and verified today, it could go back to 5.9.

#7 @fusecp
3 weeks ago

Tested 53377.2.patch and its working fine with WebPI

#8 @fusecp
3 weeks ago

  • Keywords needs-testing removed
Note: See TracTickets for help on using tickets.