Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#53377 closed defect (bug) (fixed)

WebPI parameters.xml whitespace

Reported by: fusecp's profile fusecp Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.1
Component: General Keywords: has-patch dev-feedback
Focuses: Cc:

Description

The wordpress wp-config.php file was updates to include spaces in the define strings but the WebPI was not updated to match these strings so newer versions of the WebPI are no longer working.

I have attached a fixed version of the parameters.xml which should be included in the IIS builds.

Attachments (4)

parameters.xml (11.7 KB) - added by fusecp 3 years ago.
53377.patch (3.2 KB) - added by fusecp 2 years ago.
Patch file for changes
53377.2.patch (3.2 KB) - added by sabernhardt 2 years ago.
matching zero or more spaces
53377.3.patch (5.5 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (19)

@fusecp
3 years ago

#1 @SergeyBiryukov
3 years ago

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Just to clarify for anyone looking at this, the file appears to be located at branches/iis/parameters.xml.

#2 @SergeyBiryukov
3 years ago

  • Version changed from 5.7.2 to 5.1

Setting the version to 5.1, as the change was made in [42343/trunk/wp-config-sample.php] / #41057.

#3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#4 @sabernhardt
2 years ago

  • Keywords needs-patch added
  • Milestone changed from 5.9 to 6.0

A .diff (patch) file would help.

To be thorough, I think the match pattern could accommodate either with or without spaces (but include the spaces in defaultValue).

Version 0, edited 2 years ago by sabernhardt (next)

@fusecp
2 years ago

Patch file for changes

#5 @fusecp
2 years ago

The current match pattern without spaces did not work as we have tested this with WebPI. The values never get replaced.

In the past there was a third party git repo used by WebPI apps but i think it would be best if we fix this in your files and allow customers to download from yourself.

If this can be added to 5.9 that would be great.

@sabernhardt
2 years ago

matching zero or more spaces

#6 @sabernhardt
2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Thanks for the quick patch!

I meant using the \s* wildcard for zero or more spaces. It had been after a few commas, and this adds it before and after the quotes.

Note that I edited the patch file directly, so there easily could be an error with it.

If this can be tested and verified today, it could go back to 5.9.

#7 @fusecp
2 years ago

Tested 53377.2.patch and its working fine with WebPI

#8 @fusecp
2 years ago

  • Keywords needs-testing removed

This ticket was mentioned in Slack in #core by costdev. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by costdev. View the logs.


2 years ago

This ticket was mentioned in Slack in #hosting-community by costdev. View the logs.


2 years ago

#12 @costdev
2 years ago

  • Keywords dev-feedback added

This ticket was discussed in the bug scrub. I've asked for input from #hosting-community Slack channel members and it would be good to get input from those rolling their own local IIS server on Windows.

#13 @SergeyBiryukov
2 years ago

It looks like 53377.2.patch updates defaultValue for some parameters, but not for others.

53377.3.patch is a refresh that consistently updates all the parameters.

I think this is safe to commit, as the current file doesn't seem to work anyway after [42343] / #41057.

It was not quite clear to me whether there are any further steps involved for newer WebPI versions to work again, besides updating this file. After some investigation, it looks like the file is included in IIS builds, as seen in the last column in the tables on the Releases page.

Looking at the previous update in [26870] / #26696, as well as the complete file history, there are no other steps mentioned, so let's go with this for now, comment:7 appears to confirm that updating the file should be enough.

#14 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53320:

General: Account for WordPress coding standards in the Microsoft IIS configuration.

This makes sure that the rules for database credentials and authentication keys account for the spaces added as part of the formatting changes to match the WordPress coding standards in [42343/trunk/wp-config-sample.php] / #41057.

Follow-up to [42218], [42343].

Props fusecp, sabernhardt, costdev, SergeyBiryukov.
Fixes #53377.

This ticket was mentioned in Slack in #core by sergey. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.