Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53382 closed defect (bug) (reported-upstream)

media and text article title option is not compatible with WordPress 5.8 beta 1

Reported by: ugyensupport's profile ugyensupport Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: css Cc:

Description

Full Site Editing - not giving proper image result as it is when using media and text article title option after saving

  • image size enlarged with WordPress 5.8 beta 1

https://streamable.com/no0wph

Change History (14)

#1 @desrosj
3 years ago

  • Keywords needs-patch added; needs-design removed
  • Milestone changed from Awaiting Review to 5.8

Thanks for this report, @ugyensupport! Moving to the 5.8 milestone for investigation.

#2 @desrosj
3 years ago

  • Component changed from Media to Editor

#3 @sabernhardt
3 years ago

  • Focuses css added

Related: https://github.com/WordPress/gutenberg/issues/23244#issuecomment-686849179

The editor has height: auto for the image that is larger than its container so both dimensions resize. On the live site, however, neither the editor's front-end block styles nor the TT1 Blocks theme supplies that when the width is set to 100%.

(TT1 Blocks does resize the height for images within image blocks, though: .wp-block-image img {height: auto;})

Last edited 3 years ago by sabernhardt (previous) (diff)

This ticket was mentioned in Slack in #core by chaion07. View the logs.


3 years ago

#5 @chaion07
3 years ago

Hi @ugyensupport! Thank you for reporting this.Good catch!

We reviewed the ticket during a [recent bug-scrub session in Core]https://wordpress.slack.com/archives/C02RQBWTW/p1623703439389900. Expecting someone to help out with the patch within the the release cycle period. Thank you!

Props to @jeffpaul

#6 @desrosj
3 years ago

  • Keywords reporter-feedback close added

Based on the fact that this is visible within the Full Site Editing mode, I'm thinking this should be punted to 5.9, or moved over and reported upstream.

I've been trying, but I cannot reproduce using Twenty Twenty-One in a post or page. @ugyensupport if you are able to, can you provide some steps to see the issue in 5.8 beta 1 without the Gutenberg plugin active?

#7 @ugyensupport
3 years ago

@desrosj In regard to active Twenty Twenty one theme I doesn't give any blocks when we opt media and text option.
The main concern here is when we activate the Full Site Editing theme with Gutenberg it doesn't functions as expected. If am not wrong the WordPress 5.8 is all about FSE and it works only with activated Gutenberg.

This theme was built for the WordPress experimental full site editing feature. You need to install and activate the Gutenberg plugin to make it work.

@chaion07 Great thanks

#8 @desrosj
3 years ago

  • Keywords close removed

5.8 will include many of the blocks needed for FSE to be successful, but FSE will not work with 5.8 unless the Gutenberg plugin is also present and active on the site.

Unless this can be reproduced in the block without Gutenberg active, or a patch can be presented and tested before beta 3 on 22 June, I'm thinking this will be a punt to 5.9.

This ticket was mentioned in Slack in #core-editor by desrosj. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#11 @desrosj
3 years ago

  • Keywords needs-patch reporter-feedback removed
  • Milestone 5.8 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed
  • Version trunk deleted

@ugyensupport [51193] will make it harder to see the message you shared that is visible on the front end of the site.

I think the best way forward is to close this out in favor of upstream issues in the Gutenberg repository where some wider testing can be done to see whether this is a problem in other themes as well.

If anyone disagrees, feel free to reopen.

#12 @ugyensupport
3 years ago

@desrosj and #core team
How could I reproduce this issue

  1. Update your WordPress test site with WordPress 5.8 RC 1
  2. Install Gutenberg to support Full Site Editing
  3. On my end I choosed TT1 Block theme that supports Full Site Editing
  4. Choose Post or Page
  5. Select Media with Text option
  6. Update/Save your WordPress Site
  7. Here you could see the issue that I have reported above.

Note: If WordPress 5.8 Includes FSE then this changes is must added if not to WordPress 5.9 as I have had heard from the sources that FSE will be fully included in WordPress 5.9

#13 @desrosj
3 years ago

WordPress 5.8 does not include Full Site Editing. The plugin is still required for this.

Additionally, the TT1 block theme is not maintained through Trac. Issues with that theme can be submitted here: https://github.com/WordPress/theme-experiments/tree/master/tt1-blocks. It seems the issue is either in TT1, or Gutenberg.

#14 @ugyensupport
3 years ago

Version 0, edited 3 years ago by ugyensupport (next)
Note: See TracTickets for help on using tickets.