Opened 5 years ago
Closed 5 years ago
#53394 closed defect (bug) (fixed)
@global $wp_widget_factory is used but not define in documentation of this function sanitize_widget_instance( $value, $id_base = null )
| Reported by: | jontyravi | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.8 |
| Component: | Widgets | Version: | 5.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | docs |
Description
@global $wp_widget_factory is used but not define in documentation of this function sanitize_widget_instance( $value, $id_base = null )
Attachments (12)
Change History (19)
#2
in reply to: ↑ 1
@
5 years ago
- Keywords needs-refresh removed
Hi @audrasjb,
Thanks for sharing this thing and I have uploaded a new patch with the all the above changes
#3
follow-up:
↓ 4
@
5 years ago
Thank you. However, for WP coding standards compliance, we need a newline before and after the @global declaration. To clarify, here is what we need:
* @since 3.9.0
*
* @global WP_Widget_Factory $wp_widget_factory
*
* @param array $value Widget instance to sanitize.
(feel free to delete the previous diff files when your patch is somehow uploaded multiple times ;)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hello @jontyravi, thank you for the patch(s),
It looks like there is a small indentation issue on the line you added. Also, there should be a new empty line between @since and @global declarations.