WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 5 months ago

#53401 closed feature request (wontfix)

Streamable.com Embeds

Reported by: gbynumbain Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords:
Focuses: Cc:

Description

Hi,

I’m an employee at Streamable.com.

Would it be possible for us to be added to WordPress.org as a native option in the block editor? We support oEmbed and would be happy to provide any more relevant information.

Change History (8)

#1 @jorbin
6 months ago

Hi @gbynumbain, Thanks for this ticket, and welcome to Trac!

We have a set of questions regarding whitelisting oEmbed providers which I'd ask you to answer: https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

#2 follow-up: @gbynumbain
6 months ago

Thank you, and the answers to your questions are below:

Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”
Yes, we are confident that core developers have heard of us. We are mainstream.

If similar services are already supported, how does this service compare in terms of size, features, and backing?
Streamble is much smaller in size and features. We were recently acquired by Hopin, Ltd., so our backing is phenomenal.

Does this service have a large following on Twitter, Facebook, or other social media?  Is its Twitter account verified?
We have a little over 1800 followers on Twitter and close to 3300 followers on Facebook. Our Twitter account is not verified.

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)
Yes. You can find our documentation here: https://support.streamable.com/api-documentation

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
The oEmbed endpoint doesn’t work with oEmbed auto-discovery, and since it’s read only, it can’t be made to work with additional HTML tags or attributes.

Does the service make an effort to build relationships with developers, such as through robust APIs?
Yes, our API is heavily used by developers.

How old is the service?
The service is 7 years old.

Does it have a well-established Wikipedia article? (Seriously.)
The service doesn’t have a well-established Wikipedia article.

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?
No one has written a WordPress plugin that leverages the service.

Is the provider frequently proposed?
The provider isn’t frequently proposed.

#3 in reply to: ↑ 2 @peterwilsoncc
6 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to gbynumbain:

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
The oEmbed endpoint doesn’t work with oEmbed auto-discovery, and since it’s read only, it can’t be made to work with additional HTML tags or attributes.

I tested with the URL provided on the documentation page, https://streamable.com/hn8hq, and auto-discovery is working. Videos play as expected.

I'm going to close this ticket as wontfix as there is no need to add services that work with auto-discovery to the allow list.

To see auto-discovery in effect, copy https://streamable.com/hn8hq in to it's own paragraph in the WordPress editor.

#4 @gbynumbain
5 months ago

Sorry for the confusion. I thought auto-discovery was another feature. Some of our users who use WordPress.com are having issues with auto-discovery and our embed codes. When they use auto-discovery on Wordpress.com's free accounts (using free themes), the video doesn't show up. When our embed code is used in the custom HTML block, the video shows up, but empty white space appears above and below the embedded video.

We reached out to Wordpress.com concerning this, and they recommended that we get your help: https://wordpress.com/forums/topic/streamable-2/#post-3688261


Last edited 5 months ago by gbynumbain (previous) (diff)

#5 follow-up: @gbynumbain
5 months ago

Could you reconsider, based on the new information I've presented?

#6 @swissspidy
5 months ago

I suppose what they recommended was for you to ask to add a new Streamable block to the Gutenberg block editor over on GitHub.

As for the list of trusted oEmbed providers in WordPress, there's no need to include Streamable there, since you are supporting oEmbed and return an <iframe> code that WordPress supports out of the box.

As mentioned, you can copy https://streamable.com/hn8hq in to its own paragraph in the WordPress editor and will get embedded automatically.

#7 in reply to: ↑ 5 ; follow-up: @peterwilsoncc
5 months ago

Replying to gbynumbain:

Could you reconsider, based on the new information I've presented?

The extra space you mention is coming from the embed, adding a block or adding the allow list will not affect this. You'll need to fix the css in the embeds.

#8 in reply to: ↑ 7 @gbynumbain
5 months ago

Replying to peterwilsoncc:

Replying to gbynumbain:

Could you reconsider, based on the new information I've presented?

The extra space you mention is coming from the embed, adding a block or adding the allow list will not affect this. You'll need to fix the css in the embeds.

That makes sense. I did some troubleshooting with the different versions of our embed code, and I came across another issue.

1) When using the following embed code, the video player doesn't show up at all in preview/on the published post, and there's a large white space around where it should be:

Code - <div style="width:100%;height:0px;position:relative;padding-bottom:56.250%;"><iframe src="https://streamable.com/e/2rcfys" frameborder="0" width="100%" height="100%" allowfullscreen style="width:100%;height:100%;position:absolute;left:0px;top:0px;overflow:hidden;"></iframe></div>

Wordpress.com Example: https://streamtest1566624468.wordpress.com/2021/06/24/38/

2) When using the embed code below, the video player doesn't show up in preview/on the published post, and there's a single line of white space where the video should be:
Code - <iframe src="https://streamable.com/e/2rcfys" width="560" height="315" frameborder="0" allowfullscreen></iframe>

Wordpress.com Example: https://streamtest1566624468.wordpress.com/2021/06/25/test-2/

Do you know what css parameters could be causing these issues?

Note: See TracTickets for help on using tickets.